From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: fix order of trace and fput
Date: Sun, 12 Apr 2026 12:31:04 +1000 [thread overview]
Message-ID: <review-overall-20260408122437.1364-1-christian.koenig@amd.com> (raw)
In-Reply-To: <20260408122437.1364-1-christian.koenig@amd.com>
Overall Series Review
Subject: dma-buf: fix order of trace and fput
Author: "=?UTF-8?q?Christian=20K=C3=B6nig?=" <ckoenig.leichtzumerken@gmail.com>
Patches: 2
Reviewed: 2026-04-12T12:31:04.964930
---
This is a single-patch fix for a use-after-free bug in `dma_buf_put()`. The bug is real and the fix is correct: after `fput(dmabuf->file)` drops the last reference, the dma-buf may be freed, yet the current code proceeds to call `DMA_BUF_TRACE(trace_dma_buf_put, dmabuf)` which accesses `dmabuf->name_lock`, `dmabuf->exp_name`, `dmabuf->size`, and `dmabuf->file->f_inode->i_ino` — all potentially freed memory.
The fix simply reorders the two operations so the tracepoint fires before `fput()`. This is the obvious and correct approach.
There is one tag issue that should be fixed before merging.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 2:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 12:24 [PATCH] dma-buf: fix order of trace and fput Christian König
2026-04-09 12:38 ` Andi Shyti
2026-04-12 2:31 ` Claude Code Review Bot [this message]
2026-04-12 2:31 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260408122437.1364-1-christian.koenig@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox