[PATCH v1 0/3] drm: Drop unused include of <drm/drm_pciids.h>

[PATCH v1 0/3] drm: Drop unused include of <drm/drm_pciids.h>

[Uwe Kleine-König (The Capable Hub)]

Hello,

<drm/drm_pciids.h> is only actually used in the radeon driver but
included in several others. This series drops these includes.

The obvious continuation would be to fold the definition of
radeon_PCI_IDS into the only .c file using it. But I post-pone that
until
https://lore.kernel.org/all/20260430102958.136859-2-u.kleine-koenig@baylibre.com/
is out of the way.

There are no dependencies between the patches, so I suggest that each
maintainer team applies their material to their own tree at their own
pace.

To state the obvious: This is merge window material.

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (3):
  drm/amdgpu: Drop unused include of <drm/drm_pciids.h>
  drm/gma500: Drop unused include of <drm/drm_pciids.h>
  drm/mgag200: Drop unused include of <drm/drm_pciids.h>

 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
 drivers/gpu/drm/gma500/psb_drv.c        | 1 -
 drivers/gpu/drm/mgag200/mgag200_drv.c   | 1 -
 3 files changed, 3 deletions(-)


base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
-- 
2.47.3

[PATCH v1 1/3] drm/amdgpu: Drop unused include of <drm/drm_pciids.h>

[Uwe Kleine-König (The Capable Hub)]

The <drm/drm_pciids.h> header only defines radeon_PCI_IDS which isn't
used in the amdgpu driver. So drop the useless include statement.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 8b71834a73df..1239fb32311f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -28,7 +28,6 @@
 #include <drm/drm_fbdev_ttm.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_managed.h>
-#include <drm/drm_pciids.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
-- 
2.47.3

[PATCH v1 2/3] drm/gma500: Drop unused include of <drm/drm_pciids.h>

[Uwe Kleine-König (The Capable Hub)]

The <drm/drm_pciids.h> header only defines radeon_PCI_IDS which isn't
used in the gma500 driver. So drop the useless include statement.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/gpu/drm/gma500/psb_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 039da26ef24d..f7ec6c21a9a1 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -24,7 +24,6 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_file.h>
 #include <drm/drm_ioctl.h>
-#include <drm/drm_pciids.h>
 #include <drm/drm_print.h>
 #include <drm/drm_vblank.h>
 
-- 
2.47.3

[PATCH v1 3/3] drm/mgag200: Drop unused include of <drm/drm_pciids.h>

[Uwe Kleine-König (The Capable Hub)]

The <drm/drm_pciids.h> header only defines radeon_PCI_IDS which isn't
used in the mgag200 driver. So drop the useless include statement.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/gpu/drm/mgag200/mgag200_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index c180dc3c7a58..bb315490964f 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -19,7 +19,6 @@
 #include <drm/drm_ioctl.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_module.h>
-#include <drm/drm_pciids.h>
 #include <drm/drm_print.h>
 
 #include "mgag200_drv.h"
-- 
2.47.3

Re: [PATCH v1 3/3] drm/mgag200: Drop unused include of <drm/drm_pciids.h>

[Thomas Zimmermann]

Hi

Am 30.04.26 um 12:45 schrieb Uwe Kleine-König (The Capable Hub):
> The <drm/drm_pciids.h> header only defines radeon_PCI_IDS which isn't
> used in the mgag200 driver. So drop the useless include statement.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

I'll merge this patch into drm-misc-next.

Best regards
Thomas

> ---
>   drivers/gpu/drm/mgag200/mgag200_drv.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index c180dc3c7a58..bb315490964f 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -19,7 +19,6 @@
>   #include <drm/drm_ioctl.h>
>   #include <drm/drm_managed.h>
>   #include <drm/drm_module.h>
> -#include <drm/drm_pciids.h>
>   #include <drm/drm_print.h>
>   
>   #include "mgag200_drv.h"

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Claude review: drm: Drop unused include of <drm/drm_pciids.h>

[Claude Code Review Bot]

Overall Series Review

Subject: drm: Drop unused include of <drm/drm_pciids.h>
Author: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?=
 <u.kleine-koenig@baylibre.com>
Patches: 5
Reviewed: 2026-05-05T10:38:15.414171

---

This is a straightforward, correct cleanup series. The `<drm/drm_pciids.h>` header defines only `radeon_PCI_IDS`, and none of the three modified drivers (amdgpu, gma500, mgag200) reference that macro. Each patch removes a single unused `#include` line. The patches are independent and can be merged through separate maintainer trees as the cover letter suggests.

No issues found. This is safe merge-window material.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/amdgpu: Drop unused include of <drm/drm_pciids.h>

[Claude Code Review Bot]

Patch Review

**Status: Good to go.**

The patch removes:
```c
-#include <drm/drm_pciids.h>
```
from `drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c`.

Verified: `amdgpu_drv.c` has no reference to `radeon_PCI_IDS`. The amdgpu driver uses its own PCI ID table defined via `amdgpu_pciidlist[]` and `MODULE_DEVICE_TABLE`. The include is dead code.

No concerns.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/gma500: Drop unused include of <drm/drm_pciids.h>

[Claude Code Review Bot]

Patch Review

**Status: Good to go.**

The patch removes:
```c
-#include <drm/drm_pciids.h>
```
from `drivers/gpu/drm/gma500/psb_drv.c`.

Verified: `psb_drv.c` defines its own `pciidlist[]` with Intel device IDs (Poulsbo, Moorestown, etc.) and has no reference to `radeon_PCI_IDS`. The include is dead code.

No concerns.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/mgag200: Drop unused include of <drm/drm_pciids.h>

[Claude Code Review Bot]

Patch Review

**Status: Good to go.**

The patch removes:
```c
-#include <drm/drm_pciids.h>
```
from `drivers/gpu/drm/mgag200/mgag200_drv.c`.

Verified: `mgag200_drv.c` defines its own `mgag200_pciidlist[]` with Matrox device IDs and has no reference to `radeon_PCI_IDS`. The include is dead code.

No concerns.

---
Generated by Claude Code Patch Reviewer