From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: robin.clark@oss.qualcomm.com, lumag@kernel.org,
abhinav.kumar@linux.dev, jesszhan0024@gmail.com, sean@poorly.run,
marijn.suijten@somainline.org, airlied@gmail.com,
simona@ffwll.ch, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/msm: Do not declare msm_framebuffer_init() as static
Date: Tue, 21 Apr 2026 19:09:22 +0300 [thread overview]
Message-ID: <i3scoal5ilinifiiigmutnzi4zflkp7hh7ao7xuwngsa5c6ktm@t3moisfrwmob> (raw)
In-Reply-To: <20260421125733.209568-2-tzimmermann@suse.de>
On Tue, Apr 21, 2026 at 02:51:14PM +0200, Thomas Zimmermann wrote:
> Declare msm_framebuffer_init() in msm_drv.h and remove the static
> qualifier. The function will be required in msm_fbdev.c after inlining
> msm_alloc_stolen_fb().
>
> Also move msm_framebuffer_init() before msm_framebuffer_create(), so
> that it can later be made static again. Prepares msm's fbdev emulation
> for using client buffers.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/msm/msm_drv.h | 4 ++
> drivers/gpu/drm/msm/msm_fb.c | 72 +++++++++++++++++------------------
> 2 files changed, 39 insertions(+), 37 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2026-04-21 16:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 12:51 [PATCH 0/6] drm/msm: fbdev: Use client buffers Thomas Zimmermann
2026-04-21 12:51 ` [PATCH 1/6] drm/msm: Do not declare msm_framebuffer_init() as static Thomas Zimmermann
2026-04-21 16:09 ` Dmitry Baryshkov [this message]
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 12:51 ` [PATCH 2/6] drm/msm: fbdev: Inline msm_alloc_stolen_fb() Thomas Zimmermann
2026-04-21 16:22 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 12:51 ` [PATCH 3/6] drm/msm: fbdev: Fix error reporting Thomas Zimmermann
2026-04-21 16:22 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 12:51 ` [PATCH 4/6] drm/msm: fbdev: Calculate buffer geometry with format helpers Thomas Zimmermann
2026-04-22 0:07 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 12:51 ` [PATCH 5/6] drm/msm: fbdev: Use a DRM client buffer Thomas Zimmermann
2026-04-22 0:13 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 12:51 ` [PATCH 6/6] drm/msm: Make msm_framebuffer_init() an internal interface again Thomas Zimmermann
2026-04-22 0:13 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 16:08 ` [PATCH 0/6] drm/msm: fbdev: Use client buffers Dmitry Baryshkov
2026-04-22 0:14 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=i3scoal5ilinifiiigmutnzi4zflkp7hh7ao7xuwngsa5c6ktm@t3moisfrwmob \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox