From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: fbdev: Inline msm_alloc_stolen_fb()
Date: Thu, 23 Apr 2026 08:30:53 +1000 [thread overview]
Message-ID: <review-patch2-20260421125733.209568-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20260421125733.209568-3-tzimmermann@suse.de>
Patch Review
**Status: Looks good, minor observation.**
The inlining is done correctly. The key changes are:
- The error handling for the non-stolen BO fallback is now properly nested (`if (IS_ERR(bo))` inside the first `IS_ERR(bo)` block), which is a slight improvement over the original's sequential checks.
- `mode_cmd.modifier[0] = DRM_FORMAT_MOD_LINEAR` is explicitly set, which is a no-op since `DRM_FORMAT_MOD_LINEAR` is 0 and the struct is zero-initialized. The commit message correctly notes this.
- The error cleanup path is improved with descriptive labels (`err_drm_framebuffer_remove`, `err_drm_gem_object_put`).
One observation: the `drm_gem_object_put(bo)` at `err_drm_gem_object_put` runs even on `drm_framebuffer_remove` errors. In the old code, `msm_framebuffer_init()` failure was handled by the function itself (it would `drm_gem_object_put` internally on error), and then the caller would also `ERR_CAST` without another put. Now the new code does `goto err_drm_gem_object_put` which adds an explicit put. This is correct because `msm_framebuffer_init()` takes ownership of `bos[]` on success but does NOT consume the reference on failure — the caller's `bo` still needs to be put. The existing `msm_alloc_stolen_fb()` had the same pattern at its line:
```c
drm_gem_object_put(bo);
```
so this is faithful to the original.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 22:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 12:51 [PATCH 0/6] drm/msm: fbdev: Use client buffers Thomas Zimmermann
2026-04-21 12:51 ` [PATCH 1/6] drm/msm: Do not declare msm_framebuffer_init() as static Thomas Zimmermann
2026-04-21 16:09 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 12:51 ` [PATCH 2/6] drm/msm: fbdev: Inline msm_alloc_stolen_fb() Thomas Zimmermann
2026-04-21 16:22 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude Code Review Bot [this message]
2026-04-21 12:51 ` [PATCH 3/6] drm/msm: fbdev: Fix error reporting Thomas Zimmermann
2026-04-21 16:22 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 12:51 ` [PATCH 4/6] drm/msm: fbdev: Calculate buffer geometry with format helpers Thomas Zimmermann
2026-04-22 0:07 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 12:51 ` [PATCH 5/6] drm/msm: fbdev: Use a DRM client buffer Thomas Zimmermann
2026-04-22 0:13 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 12:51 ` [PATCH 6/6] drm/msm: Make msm_framebuffer_init() an internal interface again Thomas Zimmermann
2026-04-22 0:13 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
2026-04-21 16:08 ` [PATCH 0/6] drm/msm: fbdev: Use client buffers Dmitry Baryshkov
2026-04-22 0:14 ` Dmitry Baryshkov
2026-04-22 22:30 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260421125733.209568-3-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox