Claude review: drm/msm: fbdev: Calculate buffer geometry with format helpers

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Status: Looks good.**

This patch replaces the msm-specific `align_pitch()` helper with standard DRM format helpers:

```c
fourcc = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth);
format = drm_get_format_info(dev, fourcc, DRM_FORMAT_MOD_LINEAR);
pitch = drm_format_info_min_pitch(format, 0, ALIGN(sizes->surface_width, 32));
size = ALIGN(pitch * sizes->surface_height, PAGE_SIZE);
```

The `ALIGN(sizes->surface_width, 32)` preserves the adreno 32-pixel alignment requirement that was in the old `align_pitch()`. The `drm_format_info_min_pitch()` call correctly returns `uint64_t`, and the `size` variable is updated to `u64` to match, along with the `DBG` format specifier changing from `%d` to `%llu`.

The removal of `align_pitch()` from `msm_drv.h` is safe — the grep confirms it was only used from `msm_fbdev.c`.

The removal of `mode_cmd.modifier[0] = DRM_FORMAT_MOD_LINEAR` is fine since `format` is now computed directly with `DRM_FORMAT_MOD_LINEAR` and passed to `msm_framebuffer_init()`, and the zero-initialized `mode_cmd` already has `modifier[0] == 0 == DRM_FORMAT_MOD_LINEAR`.

The `PAGE_SIZE` alignment on the buffer size is a good addition — `msm_gem_new()` likely requires page-aligned sizes internally.

---
Generated by Claude Code Patch Reviewer