From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: fix sleeping allocation under spinlock in PASID IDR
Date: Tue, 31 Mar 2026 17:50:57 +1000 [thread overview]
Message-ID: <review-overall-20260328213900.19255-1-mikhail.v.gavrilov@gmail.com> (raw)
In-Reply-To: <20260328213900.19255-1-mikhail.v.gavrilov@gmail.com>
Overall Series Review
Subject: drm/amdgpu: fix sleeping allocation under spinlock in PASID IDR
Author: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Patches: 2
Reviewed: 2026-03-31T17:50:57.526600
---
This is a single-patch fix for a real bug: `GFP_KERNEL` allocation inside a spinlock critical section, which can sleep and trigger a BUG with lockdep or `CONFIG_PREEMPT`. The fix uses the standard `idr_preload()` / `GFP_NOWAIT` pattern, which is the well-established kernel idiom for exactly this situation. The commit message is excellent — it clearly explains the bug, includes a lockdep splat, explains why a mutex isn't viable (IRQ context in `amdgpu_pasid_free_cb`), and documents the chosen solution.
**Verdict: This patch looks correct and ready to merge.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 21:39 [PATCH] drm/amdgpu: fix sleeping allocation under spinlock in PASID IDR Mikhail Gavrilov
2026-03-30 7:31 ` Lazar, Lijo
2026-03-31 7:50 ` Claude review: " Claude Code Review Bot
2026-03-31 7:50 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-30 5:30 [PATCH v2 0/2] drm/amdgpu: fix locking issues in PASID IDR management Mikhail Gavrilov
2026-03-30 5:30 ` [PATCH v2 1/2] drm/amdgpu: fix sleeping allocation under spinlock in PASID IDR Mikhail Gavrilov
2026-03-31 7:36 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260328213900.19255-1-mikhail.v.gavrilov@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox