public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dpu: eliza: Use Eliza-specific CWB array
Date: Wed, 01 Apr 2026 07:37:06 +1000	[thread overview]
Message-ID: <review-overall-20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com> (raw)
In-Reply-To: <20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com>

Overall Series Review

Subject: drm/msm/dpu: eliza: Use Eliza-specific CWB array
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patches: 2
Reviewed: 2026-04-01T07:37:06.969698

---

This is a single-patch fix for a copy-paste bug in the Eliza SoC DPU catalog definition. The `.cwb` field incorrectly references `sm8650_cwb` while `.cwb_count` correctly uses `ARRAY_SIZE(eliza_cwb)`. The fix is straightforward and correct — use the Eliza-specific CWB array as intended.

The patch is low-risk. As the commit message notes, the mismatch likely has no noticeable functional impact because the arrays are probably the same size and similar in content, but it is clearly wrong and confusing.

**One observation worth raising:** The same copy-paste bug pattern (`.cwb = sm8650_cwb` with a local `_cwb` array) appears to exist in other catalog files in the tree: `dpu_12_0_sm8750.h`, `dpu_12_2_glymur.h`, and `dpu_13_0_kaanapali.h`. The author may want to fix those in follow-up patches (or they may already be fixed in -next).

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-31 21:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 16:11 [PATCH] drm/msm/dpu: eliza: Use Eliza-specific CWB array Krzysztof Kozlowski
2026-03-31 17:56 ` Dmitry Baryshkov
2026-03-31 21:37 ` Claude Code Review Bot [this message]
2026-03-31 21:37 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox