public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dpu: eliza: Use Eliza-specific CWB array
Date: Wed, 01 Apr 2026 07:37:07 +1000	[thread overview]
Message-ID: <review-patch1-20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com> (raw)
In-Reply-To: <20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com>

Patch Review

**Verdict: Looks good.**

The fix is a one-line change that's obviously correct:

```c
 .cwb_count = ARRAY_SIZE(eliza_cwb),
-.cwb = sm8650_cwb,
+.cwb = eliza_cwb,
```

The `.cwb_count` already counted `eliza_cwb`, so `.cwb` must point to the same array. The Fixes tag and commit message are clear.

**Minor nit:** The commit message says "different register space sizes" — it might be worth noting in the message *what* actually differs between `eliza_cwb` and `sm8650_cwb` (e.g., different `len` values in the CWB block definitions), but this is not a blocker.

**Suggestion:** Consider also fixing the same pattern in `sm8750`, `glymur`, and `kaanapali` catalog headers, which appear to have the identical `.cwb = sm8650_cwb` copy-paste issue in the current drm-next tree.

Reviewed-by worthy as-is.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-31 21:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 16:11 [PATCH] drm/msm/dpu: eliza: Use Eliza-specific CWB array Krzysztof Kozlowski
2026-03-31 17:56 ` Dmitry Baryshkov
2026-03-31 21:37 ` Claude review: " Claude Code Review Bot
2026-03-31 21:37 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox