[PATCH] drm/msm/dpu: eliza: Use Eliza-specific CWB array

[PATCH] drm/msm/dpu: eliza: Use Eliza-specific CWB array

[Krzysztof Kozlowski]

The driver references CWB array from SM8650, but should use the Eliza
specific, which has different register space sizes.  This should not
have noticeable impact on function but is indeed confusing, since the
Eliza table is used for .cwb_count.

Fixes: 0eb707bbc7fc ("drm/msm/dpu: Add support for Eliza SoC")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Fix for a patch in next.
---
 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h
index b482a7e4e6c0..b93d32888972 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h
@@ -353,7 +353,7 @@ const struct dpu_mdss_cfg dpu_eliza_cfg = {
 	.wb_count = ARRAY_SIZE(eliza_wb),
 	.wb = eliza_wb,
 	.cwb_count = ARRAY_SIZE(eliza_cwb),
-	.cwb = sm8650_cwb,
+	.cwb = eliza_cwb,
 	.intf_count = ARRAY_SIZE(eliza_intf),
 	.intf = eliza_intf,
 	.vbif = &sm8650_vbif,
-- 
2.51.0

Re: [PATCH] drm/msm/dpu: eliza: Use Eliza-specific CWB array

[Dmitry Baryshkov]

On Tue, Mar 31, 2026 at 06:11:57PM +0200, Krzysztof Kozlowski wrote:
> The driver references CWB array from SM8650, but should use the Eliza
> specific, which has different register space sizes.  This should not
> have noticeable impact on function but is indeed confusing, since the
> Eliza table is used for .cwb_count.
> 
> Fixes: 0eb707bbc7fc ("drm/msm/dpu: Add support for Eliza SoC")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Fix for a patch in next.
> ---
>  drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Claude review: drm/msm/dpu: eliza: Use Eliza-specific CWB array

[Claude Code Review Bot]

Overall Series Review

Subject: drm/msm/dpu: eliza: Use Eliza-specific CWB array
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patches: 2
Reviewed: 2026-04-01T07:37:06.969698

---

This is a single-patch fix for a copy-paste bug in the Eliza SoC DPU catalog definition. The `.cwb` field incorrectly references `sm8650_cwb` while `.cwb_count` correctly uses `ARRAY_SIZE(eliza_cwb)`. The fix is straightforward and correct — use the Eliza-specific CWB array as intended.

The patch is low-risk. As the commit message notes, the mismatch likely has no noticeable functional impact because the arrays are probably the same size and similar in content, but it is clearly wrong and confusing.

**One observation worth raising:** The same copy-paste bug pattern (`.cwb = sm8650_cwb` with a local `_cwb` array) appears to exist in other catalog files in the tree: `dpu_12_0_sm8750.h`, `dpu_12_2_glymur.h`, and `dpu_13_0_kaanapali.h`. The author may want to fix those in follow-up patches (or they may already be fixed in -next).

---
Generated by Claude Code Patch Reviewer

Claude review: drm/msm/dpu: eliza: Use Eliza-specific CWB array

[Claude Code Review Bot]

Patch Review

**Verdict: Looks good.**

The fix is a one-line change that's obviously correct:

```c
 .cwb_count = ARRAY_SIZE(eliza_cwb),
-.cwb = sm8650_cwb,
+.cwb = eliza_cwb,
```

The `.cwb_count` already counted `eliza_cwb`, so `.cwb` must point to the same array. The Fixes tag and commit message are clear.

**Minor nit:** The commit message says "different register space sizes" — it might be worth noting in the message *what* actually differs between `eliza_cwb` and `sm8650_cwb` (e.g., different `len` values in the CWB block definitions), but this is not a blocker.

**Suggestion:** Consider also fixing the same pattern in `sm8750`, `glymur`, and `kaanapali` catalog headers, which appear to have the identical `.cwb = sm8650_cwb` copy-paste issue in the current drm-next tree.

Reviewed-by worthy as-is.

---
Generated by Claude Code Patch Reviewer