public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova: require little endian
Date: Sun, 12 Apr 2026 14:07:45 +1000	[thread overview]
Message-ID: <review-overall-20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com> (raw)
In-Reply-To: <20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com>

Overall Series Review

Subject: gpu: nova: require little endian
Author: Eliot Courtney <ecourtney@nvidia.com>
Patches: 7
Reviewed: 2026-04-12T14:07:45.623021

---

This is a single-patch series that adds `depends on !CPU_BIG_ENDIAN` to both `nova-core` and `nova-drm` Kconfig entries. The change is straightforward, well-motivated, and correct in intent: the nova driver code assumes little-endian byte ordering (e.g., directly interpreting GPU command queue bytes), and this makes that assumption explicit at the config level rather than leaving it implicit.

The author notes that `RUST` transitively depends on `!CPU_BIG_ENDIAN`. Checking the current tree, this is *practically* true but not *technically guaranteed*: arm64 selects `HAVE_RUST` unconditionally, but arm64's `CPU_BIG_ENDIAN` currently depends on `BROKEN` (so it's effectively unreachable). The other arch that could theoretically enable both is RISC-V, but it doesn't define `CPU_BIG_ENDIAN` at all. So while the transitive dependency holds today through indirect means, adding the explicit `depends on !CPU_BIG_ENDIAN` is the right thing to do -- it documents the driver's actual requirement rather than relying on an accidental property of the Rust toolchain's arch support.

**Verdict:** The patch is clean, minimal, and correct. No issues found.

---

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-12  4:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  3:59 [PATCH v2] gpu: nova: require little endian Eliot Courtney
2026-04-07  5:09 ` John Hubbard
2026-04-07 11:57 ` Gary Guo
2026-04-07 14:11 ` Joel Fernandes
2026-04-07 14:22 ` Danilo Krummrich
2026-04-08  6:47   ` Eliot Courtney
2026-04-08  7:12 ` Alexandre Courbot
2026-04-12  4:07 ` Claude review: " Claude Code Review Bot
2026-04-12  4:07 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox