public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova: require little endian
Date: Sun, 12 Apr 2026 14:07:45 +1000	[thread overview]
Message-ID: <review-patch1-20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com> (raw)
In-Reply-To: <20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com>

Patch Review

**Change:** Adds `depends on !CPU_BIG_ENDIAN` to both `drivers/gpu/drm/nova/Kconfig` and `drivers/gpu/nova-core/Kconfig`, placed after `depends on RUST` in each file.

**Analysis:**

1. **Correctness:** The placement is appropriate -- it follows the existing `depends on` block and comes before the `select` directives, which is consistent with Kconfig style conventions.

2. **Ordering within Kconfig:** Looking at the current tree files, the drm-next tree has slightly different ordering from the patch's context. The current `DRM_NOVA` starts with:
   ```
   depends on 64BIT
   depends on DRM=y
   depends on PCI
   depends on RUST
   ```
   while the patch's context shows:
   ```
   depends on DRM=y
   depends on PCI
   depends on RUST
   ```
   (missing `depends on 64BIT`). This explains why the patches didn't apply cleanly -- the base differs from drm-next. This is a rebase issue, not a patch correctness issue; the base commit `a7a080bb4236` is likely from a different tree. Not a concern for review.

3. **Scope:** Adding the dependency to both `nova-core` and `nova-drm` is correct. Since `DRM_NOVA` selects `NOVA_CORE`, the dependency on `nova-core` alone might seem sufficient, but `select` bypasses dependency checks, so having it explicit on both entries prevents broken configurations.

4. **Commit message:** Clear and well-reasoned. The cover letter discussion about making the endianness decision explicit rather than having "some handling sprinkled around" is a sensible engineering argument.

5. **v1 to v2 delta:** The author correctly dropped the v1 Reviewed-by/Acked-by tags since the patch changed substantively (adding `nova-drm` in addition to `nova-core`).

No issues. The patch is ready to merge (with a trivial rebase onto the appropriate base).

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-12  4:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  3:59 [PATCH v2] gpu: nova: require little endian Eliot Courtney
2026-04-07  5:09 ` John Hubbard
2026-04-07 11:57 ` Gary Guo
2026-04-07 14:11 ` Joel Fernandes
2026-04-07 14:22 ` Danilo Krummrich
2026-04-08  6:47   ` Eliot Courtney
2026-04-08  7:12 ` Alexandre Courbot
2026-04-12  4:07 ` Claude Code Review Bot [this message]
2026-04-12  4:07 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox