Claude review: drm/nouveau: stability fixes for NVAC (MCP79/MCP7A)

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/nouveau: stability fixes for NVAC (MCP79/MCP7A)
Author: Marek Czernohous <mczernohous@gmail.com>
Patches: 4
Reviewed: 2026-04-12T10:25:00.599272

---

This is a 3-patch series targeting stability on NVAC (MCP79) hardware, covering MSI re-arm, a NULL pointer guard in display teardown, and a DP link check retry. The author has clearly done real testing on hardware and the problems described are plausible. However, there are significant issues with accuracy in the commit messages and with the scope of the changes vs. what is described.

**Patch 1** is the strongest patch — it aligns g94 with its sibling chipsets (g84, g92) that already use the PCI config space method — but the commit message contains a factually incorrect claim about NVAA. **Patch 2** adds a defensive NULL check that prevents a crash, but the "race condition" explanation is questionable and the early-return path skips substantial cleanup. **Patch 3** is the most concerning — it adds a blanket 100ms sleep in a shared hot-plug work handler affecting all chipsets, not just the claimed NV50/G94.

The series would benefit from more accurate commit messages and, in at least one case, a narrower or better-justified fix.

---

---
Generated by Claude Code Patch Reviewer