From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/adreno: fix userspace-triggered crash on a2xx-a4xx
Date: Sun, 12 Apr 2026 08:59:45 +1000 [thread overview]
Message-ID: <review-overall-20260411-adreno-fix-ubwc-v3-1-4983156f3f80@oss.qualcomm.com> (raw)
In-Reply-To: <20260411-adreno-fix-ubwc-v3-1-4983156f3f80@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm/adreno: fix userspace-triggered crash on a2xx-a4xx
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 2
Reviewed: 2026-04-12T08:59:45.879716
---
This is a single patch (v3) fixing a **userspace-triggerable NULL pointer dereference** on Adreno a2xx through a4xx GPUs. The bug was introduced by commit `a452510aad53` which refactored UBWC configuration into a common struct and added a pointer (`ubwc_config`) that gets dereferenced in `adreno_get_param()` — but a2xx, a3xx, and a4xx GPUs never set this pointer since they predate UBWC support.
The fix is correct, minimal, and well-targeted. The approach of returning `-ENOENT` via the `UERR()` macro is consistent with how other unsupported parameter queries are handled in this function and matches the v2/v3 review feedback from Rob Clark.
**Verdict: Looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-11 22:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 14:59 [PATCH v3] drm/msm/adreno: fix userspace-triggered crash on a2xx-a4xx Dmitry Baryshkov
2026-04-11 15:22 ` Rob Clark
2026-04-11 22:59 ` Claude Code Review Bot [this message]
2026-04-11 22:59 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-07 3:23 [PATCH v2] " Dmitry Baryshkov
2026-04-12 4:10 ` Claude review: " Claude Code Review Bot
2026-04-12 4:10 ` Claude Code Review Bot
2026-04-06 22:14 [PATCH] " Dmitry Baryshkov
2026-04-12 4:17 ` Claude review: " Claude Code Review Bot
2026-04-12 4:17 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260411-adreno-fix-ubwc-v3-1-4983156f3f80@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox