From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: kunit: Add support for suppressing warning backtraces
Date: Thu, 23 Apr 2026 09:52:25 +1000 [thread overview]
Message-ID: <review-overall-20260420-kunit_add_support-v7-0-e8bc6e0f70de@redhat.com> (raw)
In-Reply-To: <20260420-kunit_add_support-v7-0-e8bc6e0f70de@redhat.com>
Overall Series Review
Subject: kunit: Add support for suppressing warning backtraces
Author: Albert Esteve <aesteve@redhat.com>
Patches: 20
Reviewed: 2026-04-23T09:52:25.890322
---
This v7 series adds KUnit infrastructure for suppressing WARN() backtraces during tests that intentionally trigger them. The approach is sound: hooks are placed at two points in the warning path (`warn_slowpath_fmt()` for non-`__WARN_FLAGS` architectures, and `__report_bug()` for `__WARN_FLAGS` architectures), with an RCU-protected per-task suppression list. The design avoids touching `include/asm-generic/bug.h` and requires no architecture-specific code.
The series is well-structured, has good test coverage, and addresses a real problem (noisy backtraces in CI from tests that intentionally pass bad parameters).
**One significant correctness issue**: The RCU-protected `suppressed_warnings` list has no write-side lock. `list_add_rcu()` and `list_del_rcu()` are called without any mutual exclusion, which is incorrect per the RCU list API contract. While KUnit tests typically run sequentially, this is a latent data corruption bug if tests ever run concurrently.
There is also a minor ordering issue in patch 2 where the atomic counter is incremented before `list_add_rcu()`, creating a window where `__kunit_is_suppressed_warning()` enters the RCU list traversal but doesn't find the entry yet. This is benign (returns false instead of true), but worth noting.
Overall: good concept, near-mergeable, needs the write-side lock fix.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 23:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 12:28 [PATCH v7 0/5] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-04-20 12:28 ` [PATCH v7 1/5] bug/kunit: Core " Albert Esteve
2026-04-20 14:39 ` Peter Zijlstra
2026-04-21 8:22 ` Albert Esteve
2026-04-20 14:45 ` Peter Zijlstra
2026-04-21 8:29 ` Albert Esteve
2026-04-22 12:19 ` David Gow
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 ` [PATCH v7 2/5] bug/kunit: Reduce runtime impact of warning backtrace suppression Albert Esteve
2026-04-20 14:44 ` Peter Zijlstra
2026-04-21 8:41 ` Albert Esteve
2026-04-22 12:19 ` David Gow
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 ` [PATCH v7 3/5] kunit: Add backtrace suppression self-tests Albert Esteve
2026-04-22 12:20 ` David Gow
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 ` [PATCH v7 4/5] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-04-20 14:47 ` Peter Zijlstra
2026-04-21 8:49 ` Albert Esteve
2026-04-21 11:50 ` Jani Nikula
2026-04-22 12:20 ` David Gow
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 ` [PATCH v7 5/5] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-04-22 12:20 ` David Gow
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
2026-04-22 23:52 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-04 7:41 [PATCH v8 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-04 22:33 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260420-kunit_add_support-v7-0-e8bc6e0f70de@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox