From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: kunit: Add support for suppressing warning backtraces
Date: Tue, 05 May 2026 08:33:31 +1000 [thread overview]
Message-ID: <review-overall-20260504-kunit_add_support-v8-0-3e5957cdd235@redhat.com> (raw)
In-Reply-To: <20260504-kunit_add_support-v8-0-3e5957cdd235@redhat.com>
Overall Series Review
Subject: kunit: Add support for suppressing warning backtraces
Author: Albert Esteve <aesteve@redhat.com>
Patches: 6
Reviewed: 2026-05-05T08:33:31.036374
---
This v8 series adds a KUnit API for suppressing WARN*() backtraces during unit tests, a well-motivated feature that has been through extensive iteration. The design is sound: task-scoped suppression integrated into the existing KUnit hooks mechanism with zero overhead when tests aren't running (via the `kunit_running` static key). The three API forms (scoped, manual macros, direct functions) cover the right use cases.
The implementation is solid overall. RCU-protected reader path with spinlock-protected writer side is the correct approach. The placement of suppression checks at three points in the warning path (warn_slowpath_fmt, __warn_printk, __report_bug) is well-considered, and the `count` parameter to avoid double-counting is a nice detail. The test coverage is thorough, including cross-kthread isolation.
I have a few concerns, mostly minor, detailed below.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 22:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 7:41 [PATCH v8 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-04 7:41 ` [PATCH v8 1/4] bug/kunit: Core " Albert Esteve
2026-05-04 22:33 ` Claude review: " Claude Code Review Bot
2026-05-04 7:41 ` [PATCH v8 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-04 22:33 ` Claude review: " Claude Code Review Bot
2026-05-04 7:41 ` [PATCH v8 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-04 10:03 ` Maxime Ripard
2026-05-04 22:33 ` Claude review: " Claude Code Review Bot
2026-05-04 7:41 ` [PATCH v8 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-04 22:33 ` Claude review: " Claude Code Review Bot
2026-05-04 22:33 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-20 12:28 [PATCH v7 0/5] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260504-kunit_add_support-v8-0-3e5957cdd235@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox