public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Suppress intentional warning backtraces in scaling unit tests
Date: Tue, 05 May 2026 08:33:31 +1000	[thread overview]
Message-ID: <review-patch3-20260504-kunit_add_support-v8-3-3e5957cdd235@redhat.com> (raw)
In-Reply-To: <20260504-kunit_add_support-v8-3-3e5957cdd235@redhat.com>

Patch Review

**Clean and minimal.** This wraps the drm_rect_calc_hscale/vscale calls in `kunit_warning_suppress(test)` blocks.

```c
+	kunit_warning_suppress(test) {
+		scaling_factor = drm_rect_calc_hscale(&params->src, &params->dst,
+						      params->min_range,
+						      params->max_range);
+	}
```

**Minor observation:** The suppression is applied unconditionally to all parameterized test cases, including those where the parameters are valid and no warning would fire. This is harmless (suppression has negligible overhead since the check only happens in the warn slow path), but it means the counter would be 0 for non-warning cases. This is fine — suppressing when no warning fires is cheaper than conditionally wrapping.

**Minor nit:** The comment says "This affects all unit tests with an error code in expected_scaling_factor" — it would be slightly more precise to say "negative" rather than "error code", but this is a matter of taste.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-04 22:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04  7:41 [PATCH v8 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-04  7:41 ` [PATCH v8 1/4] bug/kunit: Core " Albert Esteve
2026-05-04 22:33   ` Claude review: " Claude Code Review Bot
2026-05-04  7:41 ` [PATCH v8 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-04 22:33   ` Claude review: " Claude Code Review Bot
2026-05-04  7:41 ` [PATCH v8 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-04 10:03   ` Maxime Ripard
2026-05-04 22:33   ` Claude Code Review Bot [this message]
2026-05-04  7:41 ` [PATCH v8 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-04 22:33   ` Claude review: " Claude Code Review Bot
2026-05-04 22:33 ` Claude review: kunit: Add support for suppressing warning backtraces Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20 12:28 [PATCH v7 0/5] " Albert Esteve
2026-04-20 12:28 ` [PATCH v7 4/5] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-04-22 23:52   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260504-kunit_add_support-v8-3-3e5957cdd235@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox