public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Suppress intentional warning backtraces in scaling unit tests
Date: Thu, 23 Apr 2026 09:52:27 +1000	[thread overview]
Message-ID: <review-patch4-20260420-kunit_add_support-v7-4-e8bc6e0f70de@redhat.com> (raw)
In-Reply-To: <20260420-kunit_add_support-v7-4-e8bc6e0f70de@redhat.com>

Patch Review

**Clean and correct application of the API**

The suppression wraps the exact call that triggers warnings. The comments explaining why suppression is needed are appropriate, though perhaps a bit verbose for the CLAUDE.md "no comments" guidance (but that doesn't apply to kernel code conventions).

**Suppression covers all parameterized cases, not just error cases**

```c
+	KUNIT_START_SUPPRESSED_WARNING(test);
 	scaling_factor = drm_rect_calc_hscale(&params->src, &params->dst,
 					      params->min_range, params->max_range);
+	KUNIT_END_SUPPRESSED_WARNING(test);
```

This suppresses warnings for ALL parameterized test cases, including those that don't trigger warnings. This is fine (the overhead is negligible and the alternative would be conditional suppression based on `expected_scaling_factor`), but worth noting that the warning count won't always equal 1 for all parameterized cases.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-22 23:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 12:28 [PATCH v7 0/5] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-04-20 12:28 ` [PATCH v7 1/5] bug/kunit: Core " Albert Esteve
2026-04-20 14:39   ` Peter Zijlstra
2026-04-21  8:22     ` Albert Esteve
2026-04-20 14:45   ` Peter Zijlstra
2026-04-21  8:29     ` Albert Esteve
2026-04-22 12:19   ` David Gow
2026-04-22 23:52   ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 ` [PATCH v7 2/5] bug/kunit: Reduce runtime impact of warning backtrace suppression Albert Esteve
2026-04-20 14:44   ` Peter Zijlstra
2026-04-21  8:41     ` Albert Esteve
2026-04-22 12:19   ` David Gow
2026-04-22 23:52   ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 ` [PATCH v7 3/5] kunit: Add backtrace suppression self-tests Albert Esteve
2026-04-22 12:20   ` David Gow
2026-04-22 23:52   ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 ` [PATCH v7 4/5] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-04-20 14:47   ` Peter Zijlstra
2026-04-21  8:49     ` Albert Esteve
2026-04-21 11:50       ` Jani Nikula
2026-04-22 12:20   ` David Gow
2026-04-22 23:52   ` Claude Code Review Bot [this message]
2026-04-20 12:28 ` [PATCH v7 5/5] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-04-22 12:20   ` David Gow
2026-04-22 23:52   ` Claude review: " Claude Code Review Bot
2026-04-22 23:52 ` Claude review: kunit: Add support for suppressing warning backtraces Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-04  7:41 [PATCH v8 0/4] " Albert Esteve
2026-05-04  7:41 ` [PATCH v8 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-04 22:33   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260420-kunit_add_support-v7-4-e8bc6e0f70de@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox