[PATCH V2 0/1] Rust DRM build fix

[PATCH V2 0/1] Rust DRM build fix

[Mukesh Kumar Chaurasiya (IBM)]

rust drm gem shmem doesn't builds due to an import error of ARef from
types instead of sync.

Changelog:

V1 -> V2:
- Removed the 2nd patch as it was by design
- Removed unnecessary braces around the Opaque mod
- Minor change in commit message 
V1: https://lore.kernel.org/all/20260426082234.2026908-1-mkchauras@gmail.com/

Mukesh Kumar Chaurasiya (IBM) (1):
  rust/drm: import ARef from sync crate

 rust/kernel/drm/gem/shmem.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-- 
2.53.0

[PATCH V2 1/1] rust/drm: import ARef from sync crate

[Mukesh Kumar Chaurasiya (IBM)]

ARef is defined in sync and is getting used from types causing the
build to fail.

Fix this by using ARef from sync module.

Signed-off-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>
---
 rust/kernel/drm/gem/shmem.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/rust/kernel/drm/gem/shmem.rs b/rust/kernel/drm/gem/shmem.rs
index d025fb035195..e1b648920d2f 100644
--- a/rust/kernel/drm/gem/shmem.rs
+++ b/rust/kernel/drm/gem/shmem.rs
@@ -19,10 +19,8 @@
     },
     error::to_result,
     prelude::*,
-    types::{
-        ARef,
-        Opaque, //
-    }, //
+    sync::aref::ARef,
+    types::Opaque, //
 };
 use core::{
     ops::{
-- 
2.53.0

Claude review: rust/drm: import ARef from sync crate

[Claude Code Review Bot]

Patch Review

**Correctness: Good.** On drm-next, `ARef` is defined in `rust/kernel/sync/aref.rs` and is no longer present in or re-exported from `rust/kernel/types.rs`. The current code:

```rust
types::{
    ARef,
    Opaque, //
}, //
```

will indeed fail to compile. The fix changes it to:

```rust
sync::aref::ARef,
types::Opaque, //
```

This matches the convention used elsewhere in the same DRM subsystem — `rust/kernel/drm/driver.rs:14` already imports via `sync::aref::ARef`.

**Minor nit:** The trailing `//` comment on the `types::Opaque` line is a `rustfmt` artifact to force one-import-per-line formatting. That's fine and consistent with the surrounding code style (the existing code had it too). No issue here, just noting it's intentional.

**Commit message:** The commit message is adequate but could be slightly more precise. It says "ARef is defined in sync and is getting used from types causing the build to fail" — it would be clearer to say "ARef was moved from `kernel::types` to `kernel::sync::aref`" to explain *why* the import broke. This is a very minor suggestion and not a blocker.

**No functional concerns.** The change is purely an import path fix with no behavioral impact.

---
Generated by Claude Code Patch Reviewer

Re: [PATCH V2 0/1] Rust DRM build fix

[Danilo Krummrich]

On Sun, 26 Apr 2026 15:17:24 +0530, Mukesh Kumar Chaurasiya (IBM) wrote:
> [PATCH V2 0/1] Rust DRM build fix

Applied, thanks!

  Branch: drm-rust-next
  Tree:   https://gitlab.freedesktop.org/drm/rust/kernel.git

[1/1] rust/drm: import ARef from sync crate
      commit: 5f69165b7e42

      [ Add missing Fixes: tag. - Danilo ]

The patch will appear in the next linux-next integration (typically within 24
hours on weekdays).

The patch is queued up for the upcoming merge window for the next major kernel
release.

Claude review: Rust DRM build fix

[Claude Code Review Bot]

Overall Series Review

Subject: Rust DRM build fix
Author: "Mukesh Kumar Chaurasiya (IBM)" <mkchauras@gmail.com>
Patches: 3
Reviewed: 2026-04-28T15:19:57.516627

---

This is a simple single-patch build fix for the Rust DRM GEM shmem helper. The `ARef` type was moved from `kernel::types` to `kernel::sync::aref` (as part of broader Rust kernel reorganization), but the import in `shmem.rs` was not updated, causing a compile failure. The fix is correct and consistent with how other files in the same subsystem already import `ARef`.

**Verdict: The patch looks correct and ready to apply.** One minor nit on style below.

---
Generated by Claude Code Patch Reviewer

[PATCH V1 0/2] Rust DRM build fix

[Mukesh Kumar Chaurasiya (IBM)]

rust drm gem shmem doesn't builds due to an import error of ARef from
types instead of sync.

This series fixes that and also makes CONFIG_RUST_DRM_GEM_SHMEM_HELPER
dependent of RUST and making it selectable from menuconfig.

Mukesh Kumar Chaurasiya (IBM) (2):
  rust/drm: import ARef from sync crate
  drm: Make CONFIG_RUST_DRM_GEM_SHMEM_HELPER selectable from menuconfig

 drivers/gpu/drm/Kconfig      | 4 ++--
 rust/kernel/drm/gem/shmem.rs | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.53.0

Claude review: Rust DRM build fix

[Claude Code Review Bot]

Overall Series Review

Subject: Rust DRM build fix
Author: "Mukesh Kumar Chaurasiya (IBM)" <mkchauras@gmail.com>
Patches: 4
Reviewed: 2026-04-28T15:21:52.284046

---

This is a 2-patch series fixing build issues with the Rust DRM GEM shmem helper code. Patch 1 fixes a genuine import error (`ARef` moved from `types` to `sync::aref`). Patch 2 makes the Kconfig option user-selectable and adds a `RUST` dependency. 

Patch 1 is a correct and necessary fix. Patch 2 has issues — adding the `RUST` dependency is fine, but changing the option from a hidden `bool` to a user-selectable one deviates from the established kernel pattern for helper configs and should be reconsidered.

---
Generated by Claude Code Patch Reviewer