public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE
Date: Tue, 05 May 2026 11:36:17 +1000	[thread overview]
Message-ID: <review-overall-20260429140024.192432-1-arnd@kernel.org> (raw)
In-Reply-To: <20260429140024.192432-1-arnd@kernel.org>

Overall Series Review

Subject: drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE
Author: Arnd Bergmann <arnd@kernel.org>
Patches: 4
Reviewed: 2026-05-05T11:36:17.719753

---

This is a single patch from Arnd Bergmann fixing a Kconfig dependency issue where `DRM_OF_DISPLAY_MODE_BRIDGE` (which depends on `OF`) gets force-selected by `DRM_IMX_PARALLEL_DISPLAY` and `DRM_IMX_LDB` even when `OF` is disabled (reachable via `COMPILE_TEST`). The Kconfig `select` mechanism notoriously overrides `depends on`, so the selecting symbols must carry the dependency themselves.

The fix is correct and the standard approach for this class of Kconfig problem. The patch is minimal and well-targeted.

**Note:** This patch does not apply cleanly to the current drm-next tree. In drm-next, the `DRM_OF_DISPLAY_MODE_BRIDGE` symbol has already been renamed to `DRM_IMX_LEGACY_BRIDGE`, and that renamed config no longer carries a `depends on OF` (only `depends on DRM_IMX`). However, `DRM_IMX_LEGACY_BRIDGE` still uses `of_get_drm_display_mode()` per its own help text, so the underlying issue may persist in a different form on drm-next — the OF dependency was apparently dropped during the rename rather than being pushed to the callers. The patch is presumably targeting the tree where `DRM_OF_DISPLAY_MODE_BRIDGE` still exists.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-05  1:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 14:00 [PATCH] drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE Arnd Bergmann
2026-04-30  7:17 ` Luca Ceresoli
2026-04-30  8:07   ` Damon Ding
2026-05-04 10:18 ` Luca Ceresoli
2026-05-05  1:36 ` Claude review: " Claude Code Review Bot
2026-05-05  1:36 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260429140024.192432-1-arnd@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox