public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE
Date: Tue, 05 May 2026 11:36:17 +1000	[thread overview]
Message-ID: <review-patch1-20260429140024.192432-1-arnd@kernel.org> (raw)
In-Reply-To: <20260429140024.192432-1-arnd@kernel.org>

Patch Review

**Subject line typo:** The subsystem prefix is `drm/ipv3` but should be `drm/ipuv3` (missing the "u"). The Kconfig and directory are both `ipuv3`.

**Commit message:** Clear and well-structured. The Kconfig dependency resolution output pasted in the body immediately makes the problem obvious:
```
Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && OF [=n]
Selected by [y]:
- DRM_IMX_PARALLEL_DISPLAY [=y] && ...
- DRM_IMX_LDB [=y] && ...
```

**Code changes — correct and minimal:**

```diff
 config DRM_IMX_PARALLEL_DISPLAY
 	tristate "Support for parallel displays"
 	depends on DRM_IMX
+	depends on OF
```

```diff
 config DRM_IMX_LDB
 	tristate "Support for LVDS displays"
 	depends on DRM_IMX
 	depends on COMMON_CLK
+	depends on OF
```

Both additions are correct. The dependency chain that enables the `OF=n` path is: `COMPILE_TEST` → `IMX_IPUV3_CORE` → `DRM_IMX` → `DRM_IMX_PARALLEL_DISPLAY`/`DRM_IMX_LDB` → (selects) `DRM_OF_DISPLAY_MODE_BRIDGE`, and `DRM_OF_DISPLAY_MODE_BRIDGE` depends on `OF`. Adding `depends on OF` to the selectors prevents the broken configuration.

**Minor observations:**

1. `DRM_IMX_HDMI` in the same file already has `depends on DRM_IMX && OF`, so there is precedent for per-sub-option OF dependencies here.

2. An alternative approach would be to add `depends on OF` to `DRM_IMX` itself, which would cascade to all sub-options. This would be cleaner if all sub-options require OF (which seems likely for an i.MX DRM driver), but would also affect `DRM_IMX_TVE` which currently has no OF dependency. The per-option approach in this patch is the safer, more targeted fix.

**Verdict:** The fix is correct. The subject typo (`ipv3` → `ipuv3`) should be fixed before applying.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-05  1:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 14:00 [PATCH] drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE Arnd Bergmann
2026-04-30  7:17 ` Luca Ceresoli
2026-04-30  8:07   ` Damon Ding
2026-05-04 10:18 ` Luca Ceresoli
2026-05-05  1:36 ` Claude review: " Claude Code Review Bot
2026-05-05  1:36 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260429140024.192432-1-arnd@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox