Claude review: gpu: drm: nova: enable calling into nova-core

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: drm: nova: enable calling into nova-core
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 17
Reviewed: 2026-05-05T10:17:58.324245

---

This series introduces a Nova-local workaround for `nova-drm` to call into `nova-core` by (1) fixing modpost buffer issues with long Rust symbols, (2) renaming the module to enable composite builds, (3) generating EXPORT_SYMBOL_GPL wrappers and .rmeta metadata for Rust cross-crate linking, and (4) demonstrating the interaction with a POC patch.

**The approach is reasonable as a temporary workaround** for the missing Rust cross-crate build system support. The modpost fixes (patches 1-2) are genuine bugfixes that stand on their own. The module rename (patch 3) is a necessary prerequisite. The export/metadata machinery (patches 4-6) is the core of the workaround and is clearly marked as temporary. Patch 7 (POC) is explicitly not for merging.

**Key concerns:**
- The modpost truncation detection (patch 1) is a real bug fix and should be separated from the Nova-specific series, as it affects all kernel module builds.
- The `SZ` bump to 1024 in patch 2 is arbitrary — a more principled approach (or dynamic allocation) would be more robust, though modpost being userspace makes the stack buffer acceptable.
- The rmeta build in patch 5 has a potential race condition concern worth discussing.
- Patch 7 reaches through `drvdata` from the auxiliary child to the PCI parent's private data, which couples `nova-drm` tightly to `nova-core`'s internal layout — fine for a POC, but the real API should be more structured.

---

---
Generated by Claude Code Patch Reviewer