From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: scripts: modpost: increase buf_printf's buffer size
Date: Tue, 05 May 2026 10:17:58 +1000 [thread overview]
Message-ID: <review-patch2-20260430-nova-exports-v1-2-7ca31664e983@nvidia.com> (raw)
In-Reply-To: <20260430-nova-exports-v1-2-7ca31664e983@nvidia.com>
Patch Review
**Verdict: Acceptable, but the choice of 1024 is arbitrary.**
```c
-#define SZ 500
+#define SZ 1024
```
The change doubles the buffer. 500 was already arbitrary. 1024 is fine for now, but as Rust symbol mangling is verbose, this could be exceeded again in the future. The commit message justifies it well — modpost is userspace, so stack usage isn't a concern.
Worth considering: would it be more robust to `malloc`/`realloc` or use `asprintf` instead of a fixed stack buffer? This would eliminate the truncation problem entirely. That said, this is a minimal fix and the truncation detection in patch 1 would catch future overflow, so this is acceptable as-is.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-05 0:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 14:55 [PATCH 0/7] gpu: drm: nova: enable calling into nova-core Alexandre Courbot
2026-04-30 14:55 ` [PATCH 1/7] scripts: modpost: detect and report truncated buf_printf() output Alexandre Courbot
2026-05-05 0:17 ` Claude review: " Claude Code Review Bot
2026-04-30 14:55 ` [PATCH 2/7] scripts: modpost: increase buf_printf's buffer size Alexandre Courbot
2026-05-01 13:02 ` Gary Guo
2026-05-01 15:31 ` Miguel Ojeda
2026-05-05 0:17 ` Claude Code Review Bot [this message]
2026-04-30 14:55 ` [PATCH 3/7] gpu: nova-core: rename module from nova_core to nova-core Alexandre Courbot
2026-04-30 15:07 ` Joel Fernandes
2026-05-01 3:25 ` Alexandre Courbot
2026-05-01 10:38 ` John Hubbard
2026-05-01 12:31 ` Danilo Krummrich
2026-05-05 0:17 ` Claude review: " Claude Code Review Bot
2026-04-30 14:55 ` [PATCH 4/7] gpu: nova-core: export Rust symbols for dependent modules Alexandre Courbot
2026-04-30 15:22 ` Joel Fernandes
2026-05-01 3:30 ` Alexandre Courbot
2026-05-01 10:24 ` Miguel Ojeda
2026-05-05 0:17 ` Claude review: " Claude Code Review Bot
2026-04-30 14:55 ` [PATCH 5/7] gpu: nova-core: emit Rust metadata " Alexandre Courbot
2026-05-05 0:17 ` Claude review: " Claude Code Review Bot
2026-04-30 14:55 ` [PATCH 6/7] gpu: drm: nova: build after nova-core metadata Alexandre Courbot
2026-05-05 0:17 ` Claude review: " Claude Code Review Bot
2026-04-30 14:55 ` [PATCH POC 7/7] drm: nova: demonstrate interaction with nova-core Alexandre Courbot
2026-05-05 0:17 ` Claude review: gpu: drm: nova: enable calling into nova-core Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260430-nova-exports-v1-2-7ca31664e983@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox