public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata() call
Date: Tue, 05 May 2026 09:31:02 +1000	[thread overview]
Message-ID: <review-overall-20260501080818.955914-1-john.madieu.xa@bp.renesas.com> (raw)
In-Reply-To: <20260501080818.955914-1-john.madieu.xa@bp.renesas.com>

Overall Series Review

Subject: drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata() call
Author: John Madieu <john.madieu.xa@bp.renesas.com>
Patches: 3
Reviewed: 2026-05-05T09:31:02.038117

---

This is a single, straightforward cleanup patch that removes a duplicate `platform_set_drvdata()` call in `rzg2l_mipi_dsi_probe()`. The analysis is correct: the call appears at line 1405 (immediately after `devm_drm_bridge_alloc()`) and again at line 1444 (after reset controller acquisition). No code between the two calls reads the driver data via `platform_get_drvdata()` or `dev_get_drvdata()`, so both calls are equivalent and one is genuinely redundant.

The v2 change (dropping the first occurrence instead of the second) is a reasonable choice — keeping the call closer to where `pm_runtime_enable()` and other code that might trigger callbacks is slightly more conventional, though it doesn't matter functionally since `dsi` doesn't change between the two calls.

**Verdict: Patch looks correct and ready to apply.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-04 23:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01  8:08 [PATCH v2] drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata() call John Madieu
2026-05-01  8:18 ` Biju Das
2026-05-01  8:21   ` John Madieu
2026-05-04 23:31 ` Claude Code Review Bot [this message]
2026-05-04 23:31 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260501080818.955914-1-john.madieu.xa@bp.renesas.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox