public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata() call
Date: Tue, 05 May 2026 09:31:02 +1000	[thread overview]
Message-ID: <review-patch1-20260501080818.955914-1-john.madieu.xa@bp.renesas.com> (raw)
In-Reply-To: <20260501080818.955914-1-john.madieu.xa@bp.renesas.com>

Patch Review

**Correctness: OK**

Confirmed in the source tree that there are indeed two identical calls:
- Line 1405: `platform_set_drvdata(pdev, dsi);` (right after `devm_drm_bridge_alloc`)
- Line 1444: `platform_set_drvdata(pdev, dsi);` (after reset controller acquisition)

The `dsi` pointer is not reassigned between the two calls, and no runtime callbacks that read driver data can fire before probe returns, so removing either call is safe. The v2 decision to drop the *first* occurrence (line 1405) rather than the second is fine — it keeps the call closer to the `pm_runtime_enable()` at line 1446, which is the first point where PM callbacks could theoretically be invoked.

**Nit (commit message):** "occurence" in the v2 changelog should be "occurrence", but this is below the `---` line so it won't be in the git history.

**No functional concerns.** This is a clean one-line removal with no behavioral impact.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-04 23:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01  8:08 [PATCH v2] drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata() call John Madieu
2026-05-01  8:18 ` Biju Das
2026-05-01  8:21   ` John Madieu
2026-05-04 23:31 ` Claude Code Review Bot [this message]
2026-05-04 23:31 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260501080818.955914-1-john.madieu.xa@bp.renesas.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox