From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: boe-tv101wum-nl6: restore MODE_LPM after sending disable cmds
Date: Tue, 05 May 2026 08:45:16 +1000 [thread overview]
Message-ID: <review-overall-20260503091708.1079962-1-zhengxingda@iscas.ac.cn> (raw)
In-Reply-To: <20260503091708.1079962-1-zhengxingda@iscas.ac.cn>
Overall Series Review
Subject: drm/panel: boe-tv101wum-nl6: restore MODE_LPM after sending disable cmds
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Patches: 2
Reviewed: 2026-05-05T08:45:16.029688
---
This is a single-patch fix for the `panel-boe-tv101wum-nl6` driver. The problem is real and well-understood: `boe_panel_disable()` clears `MIPI_DSI_MODE_LPM` so that the display-off and enter-sleep-mode commands are sent in HS mode, but it never restores the flag. On the next enable/prepare cycle, the init commands are sent without LPM set on `dsi->mode_flags`, which causes errors because the panel expects LP mode for initialization commands.
The fix is correct in principle — other panel drivers (e.g., `panel-boe-bf060y8m-aj0`, `panel-boe-td4320`, `panel-himax-hx83112b`) follow the same pattern of clearing LPM for disable commands and restoring it afterward.
**Verdict: The fix addresses a real bug and should be accepted, with one placement concern worth discussing.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 9:17 [PATCH] drm/panel: boe-tv101wum-nl6: restore MODE_LPM after sending disable cmds Icenowy Zheng
2026-05-04 6:48 ` Neil Armstrong
2026-05-04 22:45 ` Claude Code Review Bot [this message]
2026-05-04 22:45 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260503091708.1079962-1-zhengxingda@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox