public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: boe-tv101wum-nl6: restore MODE_LPM after sending disable cmds
Date: Tue, 05 May 2026 08:45:16 +1000	[thread overview]
Message-ID: <review-patch1-20260503091708.1079962-1-zhengxingda@iscas.ac.cn> (raw)
In-Reply-To: <20260503091708.1079962-1-zhengxingda@iscas.ac.cn>

Patch Review

**The bug:** In `boe_panel_disable()` (line 1322 of the current tree), the driver clears `MIPI_DSI_MODE_LPM`:

```c
boe->dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
```

This is intentional — the display-off and sleep-enter DCS commands should be sent in HS mode. However, the flag is never restored, so on the next prepare/init cycle (which doesn't independently set LPM), commands are sent in HS mode when LP mode is expected.

**The fix is correct.** The patch adds:

```c
boe->dsi->mode_flags |= MIPI_DSI_MODE_LPM;
```

This matches the established pattern in other panel drivers. The `Fixes:` tag and `Cc: stable` are appropriate since this is a clear regression-fix for the original driver commit.

**Minor placement concern:** The restore is inserted *between* `mipi_dsi_dcs_enter_sleep_mode_multi()` and the `mipi_dsi_msleep(&ctx, 150)` delay. Most other drivers that follow this pattern (e.g., `panel-boe-bf060y8m-aj0` at line 102) restore LPM *after* the final delay in the off sequence. In this driver the `mipi_dsi_msleep` is a multi-context sleep, which checks `ctx.accum_err` but doesn't issue DSI commands, so the placement is functionally harmless. Still, placing the restore **after** the `mipi_dsi_msleep()` and before the `return` would be slightly cleaner — it keeps all HS-mode operations (including the sleep delay that's part of the disable sequence) grouped together, and restores LPM only once the disable sequence is truly complete. This is a style nit, not a correctness issue.

**Commit message:** Clear, explains the problem, the fix, and the real-world impact (error messages on mt8183-kukui-kodama-sku32). Well written.

**Overall: Looks good.** Reviewed-by worthy, optionally with the minor suggestion to move the restore after the msleep.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-04 22:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03  9:17 [PATCH] drm/panel: boe-tv101wum-nl6: restore MODE_LPM after sending disable cmds Icenowy Zheng
2026-05-04  6:48 ` Neil Armstrong
2026-05-04 22:45 ` Claude Code Review Bot [this message]
2026-05-04 22:45 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260503091708.1079962-1-zhengxingda@iscas.ac.cn \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox