public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: iris: migrate to using global UBWC config
Date: Thu, 07 May 2026 12:40:16 +1000	[thread overview]
Message-ID: <review-overall-20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> (raw)
In-Reply-To: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com>

Overall Series Review

Subject: media: iris: migrate to using global UBWC config
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 8
Reviewed: 2026-05-07T12:40:16.438595

---

This is a clean, well-structured 7-patch series that migrates the Qualcomm Iris video decoder driver from maintaining its own UBWC (Universal Bandwidth Compression) configuration to using the centralized `QCOM_UBWC_CONFIG` registry. The motivation is sound: duplicating UBWC parameters (HBB, swizzle, bank spreading, etc.) per-driver is error-prone, especially since values like `highest_bank_bit` can depend on DDR type at runtime rather than being fixed constants.

The series is incrementally decomposed -- each patch replaces one parameter, which makes bisection and review straightforward. All patches carry Reviewed-by from Konrad Dybcio, Bryan O'Donoghue, and Dikshita Agarwal, plus a Tested-by from Wangao Wang. The cover letter notes this is compile-tested only by the author due to lack of Gen2 hardware, which is an honest disclosure.

The API mappings from the old per-driver values to the new central UBWC helpers are correct based on my verification of the `<linux/soc/qcom/ubwc.h>` header. One minor style concern noted below.

**Verdict: Series looks good. One minor nit on probe error handling.**

---

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-07  2:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  1:10 [PATCH v5 0/7] media: iris: migrate to using global UBWC config Dmitry Baryshkov
2026-05-07  1:10 ` [PATCH v5 1/7] media: iris: retrieve UBWC platform configuration Dmitry Baryshkov
2026-05-07  2:40   ` Claude review: " Claude Code Review Bot
2026-05-07  1:10 ` [PATCH v5 2/7] media: iris: don't specify min_acc_length in the source code Dmitry Baryshkov
2026-05-07  2:40   ` Claude review: " Claude Code Review Bot
2026-05-07  1:10 ` [PATCH v5 3/7] media: iris: don't specify highest_bank_bit " Dmitry Baryshkov
2026-05-07  2:40   ` Claude review: " Claude Code Review Bot
2026-05-07  1:10 ` [PATCH v5 4/7] media: iris: don't specify ubwc_swizzle " Dmitry Baryshkov
2026-05-07  2:40   ` Claude review: " Claude Code Review Bot
2026-05-07  1:10 ` [PATCH v5 5/7] media: iris: don't specify bank_spreading " Dmitry Baryshkov
2026-05-07  2:40   ` Claude review: " Claude Code Review Bot
2026-05-07  1:10 ` [PATCH v5 6/7] media: iris: don't specify max_channels " Dmitry Baryshkov
2026-05-07  2:40   ` Claude review: " Claude Code Review Bot
2026-05-07  1:10 ` [PATCH v5 7/7] media: iris: drop remnants of UBWC configuration Dmitry Baryshkov
2026-05-07  2:40   ` Claude review: " Claude Code Review Bot
2026-05-07  2:40 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox