From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: iris: don't specify max_channels in the source code
Date: Thu, 07 May 2026 12:40:18 +1000 [thread overview]
Message-ID: <review-patch6-20260507-iris-ubwc-v5-6-e9a3aee53c49@oss.qualcomm.com> (raw)
In-Reply-To: <20260507-iris-ubwc-v5-6-e9a3aee53c49@oss.qualcomm.com>
Patch Review
Replaces `core->iris_platform_data->ubwc_config->max_channels` (hardcoded to 8 for SM8550) with:
```c
payload = qcom_ubwc_macrotile_mode(ubwc) ? 8 : 4;
```
Per the UBWC header documentation: macrotile_mode `0` means 4-channel, `1` means 8-channel (introduced in UBWC 3.1). SM8550 with its UBWC 4.x would use 8-channel macrotiling, so `macrotile_mode` is true → 8. Matches the original.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-07 2:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 1:10 [PATCH v5 0/7] media: iris: migrate to using global UBWC config Dmitry Baryshkov
2026-05-07 1:10 ` [PATCH v5 1/7] media: iris: retrieve UBWC platform configuration Dmitry Baryshkov
2026-05-07 2:40 ` Claude review: " Claude Code Review Bot
2026-05-07 1:10 ` [PATCH v5 2/7] media: iris: don't specify min_acc_length in the source code Dmitry Baryshkov
2026-05-07 2:40 ` Claude review: " Claude Code Review Bot
2026-05-07 1:10 ` [PATCH v5 3/7] media: iris: don't specify highest_bank_bit " Dmitry Baryshkov
2026-05-07 2:40 ` Claude review: " Claude Code Review Bot
2026-05-07 1:10 ` [PATCH v5 4/7] media: iris: don't specify ubwc_swizzle " Dmitry Baryshkov
2026-05-07 2:40 ` Claude review: " Claude Code Review Bot
2026-05-07 1:10 ` [PATCH v5 5/7] media: iris: don't specify bank_spreading " Dmitry Baryshkov
2026-05-07 2:40 ` Claude review: " Claude Code Review Bot
2026-05-07 1:10 ` [PATCH v5 6/7] media: iris: don't specify max_channels " Dmitry Baryshkov
2026-05-07 2:40 ` Claude Code Review Bot [this message]
2026-05-07 1:10 ` [PATCH v5 7/7] media: iris: drop remnants of UBWC configuration Dmitry Baryshkov
2026-05-07 2:40 ` Claude review: " Claude Code Review Bot
2026-05-07 2:40 ` Claude review: media: iris: migrate to using global UBWC config Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260507-iris-ubwc-v5-6-e9a3aee53c49@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox