From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: Consolidate "sram" property definition
Date: Sat, 16 May 2026 14:53:56 +1000 [thread overview]
Message-ID: <review-overall-20260511165942.2774868-1-robh@kernel.org> (raw)
In-Reply-To: <20260511165942.2774868-1-robh@kernel.org>
Overall Series Review
Subject: dt-bindings: Consolidate "sram" property definition
Author: "Rob Herring (Arm)" <robh@kernel.org>
Patches: 10
Reviewed: 2026-05-16T14:53:56.864908
---
This is a single patch from Rob Herring (DT binding maintainer) that creates a common `sram-consumer.yaml` schema using the well-established `select: true` consumer pattern (already used by nvmem-consumer, leds-consumer, mux-consumer, etc.) and removes the duplicated `sram` property definitions from 15 individual binding files.
The approach is sound and follows established dt-bindings conventions. The common schema defines `sram` as a `phandle-array` with `items: maxItems: 1` (no arg cells), while device-specific schemas retain their own `minItems`/`maxItems` constraints and device-specific descriptions. The files that previously defined `sram` as a plain `phandle` (single entry) are compatible with the `phandle-array` definition since they retain `maxItems: 1`.
Overall this is a straightforward de-duplication cleanup. One minor concern worth raising is noted below.
**Verdict: Looks good. One minor question on the stericsson DMA40 change.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 4:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
2026-05-11 18:55 ` Linus Walleij
2026-05-11 23:09 ` Jakub Kicinski
2026-05-12 0:46 ` Mark Brown
2026-05-12 2:57 ` Liu Ying
2026-05-12 9:15 ` Lorenzo Bianconi
2026-05-13 8:22 ` Vinod Koul
2026-05-13 13:26 ` Dmitry Baryshkov
2026-05-13 17:59 ` Krzysztof Kozlowski
2026-05-14 15:18 ` Shah, Tanmay
2026-05-16 4:53 ` Claude Code Review Bot [this message]
2026-05-16 4:53 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260511165942.2774868-1-robh@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox