* [PATCH] dt-bindings: Consolidate "sram" property definition
@ 2026-05-11 16:59 Rob Herring (Arm)
2026-05-11 18:55 ` Linus Walleij
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: Rob Herring (Arm) @ 2026-05-11 16:59 UTC (permalink / raw)
To: Liu Ying, Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Vinod Koul, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, MD Danish Anwar,
Roger Quadros, Parvathi Pudi, Mohan Reddy Putluru,
Bjorn Andersson, Mathieu Poirier, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Michal Simek, Mark Brown,
Matthias Brugger, AngeloGioacchino Del Regno, Linus Walleij,
Lorenzo Bianconi, Felix Fietkau, Andrew F. Davis, Hussain Khaja,
Suman Anna, Ben Levinsky, Tanmay Shah, Erwan Leray,
Fabrice Gasnier
Cc: Roger Quadros, dri-devel, devicetree, imx, linux-arm-kernel,
linux-kernel, linux-arm-msm, freedreno, dmaengine, linux-media,
linux-rockchip, linux-stm32, netdev, linux-remoteproc,
linux-amlogic, linux-spi, linux-mediatek
The "sram" property has become a de facto standard property, so create a
common schema for it and drop all the duplicated definitions.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../imx/fsl,imx8qxp-dc-command-sequencer.yaml | 2 +-
.../devicetree/bindings/display/msm/gpu.yaml | 6 +----
.../bindings/dma/stericsson,dma40.yaml | 8 ++----
.../bindings/media/cnm,wave521c.yaml | 2 +-
.../bindings/media/nxp,imx8-jpeg.yaml | 6 ++---
.../bindings/media/rockchip,vdec.yaml | 5 ++--
.../bindings/media/st,stm32-dcmi.yaml | 6 ++---
.../devicetree/bindings/net/mediatek,net.yaml | 3 +--
.../bindings/net/ti,icssg-prueth.yaml | 2 +-
.../bindings/net/ti,icssm-prueth.yaml | 2 +-
.../remoteproc/amlogic,meson-mx-ao-arc.yaml | 7 +----
.../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 8 ------
.../bindings/remoteproc/ti,k3-r5f-rproc.yaml | 8 ------
.../remoteproc/xlnx,zynqmp-r5fss.yaml | 9 +------
.../devicetree/bindings/spi/st,stm32-spi.yaml | 10 +++----
.../bindings/sram/sram-consumer.yaml | 26 +++++++++++++++++++
16 files changed, 48 insertions(+), 62 deletions(-)
create mode 100644 Documentation/devicetree/bindings/sram/sram-consumer.yaml
diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml
index 27118f4c0d28..fd095e5742c5 100644
--- a/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml
+++ b/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml
@@ -41,7 +41,7 @@ properties:
- const: sw3
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
+ maxItems: 1
description: phandle pointing to the mmio-sram device node
required:
diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
index 04b2328903ca..358759fad8dc 100644
--- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
@@ -84,13 +84,9 @@ properties:
maxItems: 64
sram:
- $ref: /schemas/types.yaml#/definitions/phandle-array
minItems: 1
maxItems: 4
- items:
- maxItems: 1
- description: |
- phandles to one or more reserved on-chip SRAM regions.
+ description:
phandle to the On Chip Memory (OCMEM) that's present on some a3xx and
a4xx Snapdragon SoCs. See
Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
diff --git a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
index 607da11e7baa..d8f92838f4c9 100644
--- a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
+++ b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
@@ -136,13 +136,9 @@ properties:
maxItems: 1
sram:
- $ref: /schemas/types.yaml#/definitions/phandle-array
- description: A phandle array with inner size 1 (no arg cells).
- First phandle is the LCPA (Logical Channel Parameter Address) memory.
- Second phandle is the LCLA (Logical Channel Link base Address) memory.
- maxItems: 2
items:
- maxItems: 1
+ - description: LCPA (Logical Channel Parameter Address) memory.
+ - description: LCLA (Logical Channel Link base Address) memory.
memcpy-channels:
$ref: /schemas/types.yaml#/definitions/uint32-array
diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
index 6a11c1d11fb5..6cd33dfd095d 100644
--- a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
+++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
@@ -37,7 +37,7 @@ properties:
maxItems: 1
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
+ maxItems: 1
description:
The VPU uses the SRAM to store some of the reference data instead of
storing it on DMA memory. It is mainly used for the purpose of reducing
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 18cc6315a821..6ba668aa633d 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -56,10 +56,10 @@ properties:
maxItems: 5 # Wrapper and 4 slots
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
+ maxItems: 1
description:
- Optional phandle to a reserved on-chip SRAM regions. The SRAM can
- be used for descriptor storage, which may improve bus utilization.
+ The SRAM can be used for descriptor storage, which may improve bus
+ utilization.
required:
- compatible
diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
index 42022401d0ff..4f38a0ef29d8 100644
--- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
@@ -91,9 +91,8 @@ properties:
maxItems: 1
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
- description: |
- phandle to a reserved on-chip SRAM regions.
+ maxItems: 1
+ description:
Some SoCs, like rk3588 provide on-chip SRAM to store temporary
buffers during decoding.
diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
index d9fbb90b0977..7c2ddd27780f 100644
--- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
+++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
@@ -47,10 +47,10 @@ properties:
maxItems: 1
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
+ maxItems: 1
description:
- phandle to a reserved SRAM region which is used as temporary
- storage memory between DMA and MDMA engines.
+ SRAM region which is used as temporary storage memory between DMA and
+ MDMA engines.
port:
$ref: /schemas/graph.yaml#/$defs/port-base
diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index cc346946291a..6bbd83c6aaf7 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -67,8 +67,7 @@ properties:
- const: ppe
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
- description: phandle to mmio SRAM
+ maxItems: 1
mediatek,ethsys:
$ref: /schemas/types.yaml#/definitions/phandle
diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
index c296e5711848..883033b19b8f 100644
--- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
+++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
@@ -21,7 +21,7 @@ properties:
- ti,am654-sr1-icssg-prueth # for AM65x SoC family, SR1.0
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
+ maxItems: 1
description:
phandle to MSMC SRAM node
diff --git a/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
index a98ad45ca66f..9370c43bc66a 100644
--- a/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
+++ b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
@@ -24,7 +24,7 @@ properties:
- ti,am3359-prueth # for AM33x SoC family
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
+ maxItems: 1
description:
phandle to OCMC SRAM node
diff --git a/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml b/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml
index 76e8ca44906a..3f710433e937 100644
--- a/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml
@@ -48,12 +48,7 @@ properties:
minItems: 1
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
- description:
- phandles to a reserved SRAM region which is used as the memory of
- the ARC core. The region should be defined as child nodes of the
- AHB SRAM node as per the generic bindings in
- Documentation/devicetree/bindings/sram/sram.yaml
+ maxItems: 1
amlogic,secbus2:
$ref: /schemas/types.yaml#/definitions/phandle
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
index b51bb863d759..8b1ed384ef22 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
@@ -75,16 +75,8 @@ properties:
# --------------------
sram:
- $ref: /schemas/types.yaml#/definitions/phandle-array
minItems: 1
maxItems: 4
- items:
- maxItems: 1
- description: |
- phandles to one or more reserved on-chip SRAM regions. The regions
- should be defined as child nodes of the respective SRAM node, and
- should be defined as per the generic bindings in,
- Documentation/devicetree/bindings/sram/sram.yaml
allOf:
- if:
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
index 775e9b3a1938..14e6b2f817b3 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
@@ -224,16 +224,8 @@ patternProperties:
at 0x0) or 0 (BTCM at 0x0), default value is 1 if omitted.
sram:
- $ref: /schemas/types.yaml#/definitions/phandle-array
minItems: 1
maxItems: 4
- items:
- maxItems: 1
- description: |
- phandles to one or more reserved on-chip SRAM regions. The regions
- should be defined as child nodes of the respective SRAM node, and
- should be defined as per the generic bindings in,
- Documentation/devicetree/bindings/sram/sram.yaml
required:
- compatible
diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
index ee63c03949c9..c7d5e58330d6 100644
--- a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
@@ -106,20 +106,13 @@ patternProperties:
- const: rx
sram:
- $ref: /schemas/types.yaml#/definitions/phandle-array
minItems: 1
maxItems: 8
- items:
- maxItems: 1
- description: |
+ description:
phandles to one or more reserved on-chip SRAM regions. Other than TCM,
the RPU can execute instructions and access data from the OCM memory,
the main DDR memory, and other system memories.
- The regions should be defined as child nodes of the respective SRAM
- node, and should be defined as per the generic bindings in
- Documentation/devicetree/bindings/sram/sram.yaml
-
memory-region:
description: |
List of phandles to the reserved memory regions associated with the
diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
index 472e92974714..6d7d595e4ab3 100644
--- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
@@ -89,12 +89,10 @@ properties:
- const: rxm2m
sram:
- $ref: /schemas/types.yaml#/definitions/phandle
- description: |
- Phandles to a reserved SRAM region which is used as temporary
- storage memory between DMA and MDMA engines.
- The region should be defined as child node of the AHB SRAM node
- as per the generic bindings in Documentation/devicetree/bindings/sram/sram.yaml
+ maxItems: 1
+ description:
+ SRAM region which is used as temporary storage memory between DMA and
+ MDMA engines.
power-domains:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/sram/sram-consumer.yaml b/Documentation/devicetree/bindings/sram/sram-consumer.yaml
new file mode 100644
index 000000000000..f00087bd2879
--- /dev/null
+++ b/Documentation/devicetree/bindings/sram/sram-consumer.yaml
@@ -0,0 +1,26 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sram/sram-consumer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SRAM Consumers
+
+maintainers:
+ - Rob Herring <robh@kernel.org>
+
+select: true
+
+properties:
+ sram:
+ description:
+ Phandles to one or more reserved on-chip SRAM regions. The regions
+ should be defined as child nodes of the respective SRAM node, and
+ should be defined as per the generic bindings in,
+ Documentation/devicetree/bindings/sram/sram.yaml
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ maxItems: 1
+
+additionalProperties: true
+...
--
2.53.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
@ 2026-05-11 18:55 ` Linus Walleij
2026-05-11 23:09 ` Jakub Kicinski
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2026-05-11 18:55 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Liu Ying, Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Vinod Koul, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, MD Danish Anwar,
Roger Quadros, Parvathi Pudi, Mohan Reddy Putluru,
Bjorn Andersson, Mathieu Poirier, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Michal Simek, Mark Brown,
Matthias Brugger, AngeloGioacchino Del Regno, Lorenzo Bianconi,
Felix Fietkau, Andrew F. Davis, Hussain Khaja, Suman Anna,
Ben Levinsky, Tanmay Shah, Erwan Leray, Fabrice Gasnier,
Roger Quadros, dri-devel, devicetree, imx, linux-arm-kernel,
linux-kernel, linux-arm-msm, freedreno, dmaengine, linux-media,
linux-rockchip, linux-stm32, netdev, linux-remoteproc,
linux-amlogic, linux-spi, linux-mediatek
On Mon, May 11, 2026 at 6:59 PM Rob Herring (Arm) <robh@kernel.org> wrote:
> The "sram" property has become a de facto standard property, so create a
> common schema for it and drop all the duplicated definitions.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
I like it.
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
2026-05-11 18:55 ` Linus Walleij
@ 2026-05-11 23:09 ` Jakub Kicinski
2026-05-12 0:46 ` Mark Brown
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Jakub Kicinski @ 2026-05-11 23:09 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Liu Ying, Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Vinod Koul, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Paolo Abeni, MD Danish Anwar, Roger Quadros,
Parvathi Pudi, Mohan Reddy Putluru, Bjorn Andersson,
Mathieu Poirier, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, Michal Simek, Mark Brown, Matthias Brugger,
AngeloGioacchino Del Regno, Linus Walleij, Lorenzo Bianconi,
Felix Fietkau, Andrew F. Davis, Hussain Khaja, Suman Anna,
Ben Levinsky, Tanmay Shah, Erwan Leray, Fabrice Gasnier,
Roger Quadros, dri-devel, devicetree, imx, linux-arm-kernel,
linux-kernel, linux-arm-msm, freedreno, dmaengine, linux-media,
linux-rockchip, linux-stm32, netdev, linux-remoteproc,
linux-amlogic, linux-spi, linux-mediatek
On Mon, 11 May 2026 11:59:36 -0500 Rob Herring (Arm) wrote:
> .../bindings/net/ti,icssg-prueth.yaml | 2 +-
> .../bindings/net/ti,icssm-prueth.yaml | 2 +-
Acked-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
2026-05-11 18:55 ` Linus Walleij
2026-05-11 23:09 ` Jakub Kicinski
@ 2026-05-12 0:46 ` Mark Brown
2026-05-12 2:57 ` Liu Ying
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2026-05-12 0:46 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Liu Ying, Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Vinod Koul, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, MD Danish Anwar,
Roger Quadros, Parvathi Pudi, Mohan Reddy Putluru,
Bjorn Andersson, Mathieu Poirier, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Michal Simek,
Matthias Brugger, AngeloGioacchino Del Regno, Linus Walleij,
Lorenzo Bianconi, Felix Fietkau, Andrew F. Davis, Hussain Khaja,
Suman Anna, Ben Levinsky, Tanmay Shah, Erwan Leray,
Fabrice Gasnier, Roger Quadros, dri-devel, devicetree, imx,
linux-arm-kernel, linux-kernel, linux-arm-msm, freedreno,
dmaengine, linux-media, linux-rockchip, linux-stm32, netdev,
linux-remoteproc, linux-amlogic, linux-spi, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
On Mon, May 11, 2026 at 11:59:36AM -0500, Rob Herring (Arm) wrote:
> The "sram" property has become a de facto standard property, so create a
> common schema for it and drop all the duplicated definitions.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
` (2 preceding siblings ...)
2026-05-12 0:46 ` Mark Brown
@ 2026-05-12 2:57 ` Liu Ying
2026-05-12 9:15 ` Lorenzo Bianconi
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Liu Ying @ 2026-05-12 2:57 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Vinod Koul, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, MD Danish Anwar,
Roger Quadros, Parvathi Pudi, Mohan Reddy Putluru,
Bjorn Andersson, Mathieu Poirier, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Michal Simek, Mark Brown,
Matthias Brugger, AngeloGioacchino Del Regno, Linus Walleij,
Lorenzo Bianconi, Felix Fietkau, Andrew F. Davis, Hussain Khaja,
Suman Anna, Ben Levinsky, Tanmay Shah, Erwan Leray,
Fabrice Gasnier, Roger Quadros, dri-devel, devicetree, imx,
linux-arm-kernel, linux-kernel, linux-arm-msm, freedreno,
dmaengine, linux-media, linux-rockchip, linux-stm32, netdev,
linux-remoteproc, linux-amlogic, linux-spi, linux-mediatek
On Mon, May 11, 2026 at 11:59:36AM -0500, Rob Herring (Arm) wrote:
> .../imx/fsl,imx8qxp-dc-command-sequencer.yaml | 2 +-
Reviewed-by: Liu Ying <victor.liu@nxp.com> #fsl,imx8qxp-dc-command-sequencer.yaml
--
Regards,
Liu Ying
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
` (3 preceding siblings ...)
2026-05-12 2:57 ` Liu Ying
@ 2026-05-12 9:15 ` Lorenzo Bianconi
2026-05-13 8:22 ` Vinod Koul
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Lorenzo Bianconi @ 2026-05-12 9:15 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Liu Ying, Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Vinod Koul, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, MD Danish Anwar,
Roger Quadros, Parvathi Pudi, Mohan Reddy Putluru,
Bjorn Andersson, Mathieu Poirier, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Michal Simek, Mark Brown,
Matthias Brugger, AngeloGioacchino Del Regno, Linus Walleij,
Felix Fietkau, Andrew F. Davis, Hussain Khaja, Suman Anna,
Ben Levinsky, Tanmay Shah, Erwan Leray, Fabrice Gasnier,
Roger Quadros, dri-devel, devicetree, imx, linux-arm-kernel,
linux-kernel, linux-arm-msm, freedreno, dmaengine, linux-media,
linux-rockchip, linux-stm32, netdev, linux-remoteproc,
linux-amlogic, linux-spi, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 14475 bytes --]
> The "sram" property has become a de facto standard property, so create a
> common schema for it and drop all the duplicated definitions.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> .../imx/fsl,imx8qxp-dc-command-sequencer.yaml | 2 +-
> .../devicetree/bindings/display/msm/gpu.yaml | 6 +----
> .../bindings/dma/stericsson,dma40.yaml | 8 ++----
> .../bindings/media/cnm,wave521c.yaml | 2 +-
> .../bindings/media/nxp,imx8-jpeg.yaml | 6 ++---
> .../bindings/media/rockchip,vdec.yaml | 5 ++--
> .../bindings/media/st,stm32-dcmi.yaml | 6 ++---
> .../devicetree/bindings/net/mediatek,net.yaml | 3 +--
> .../bindings/net/ti,icssg-prueth.yaml | 2 +-
> .../bindings/net/ti,icssm-prueth.yaml | 2 +-
> .../remoteproc/amlogic,meson-mx-ao-arc.yaml | 7 +----
> .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 8 ------
> .../bindings/remoteproc/ti,k3-r5f-rproc.yaml | 8 ------
> .../remoteproc/xlnx,zynqmp-r5fss.yaml | 9 +------
> .../devicetree/bindings/spi/st,stm32-spi.yaml | 10 +++----
> .../bindings/sram/sram-consumer.yaml | 26 +++++++++++++++++++
> 16 files changed, 48 insertions(+), 62 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sram/sram-consumer.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml
> index 27118f4c0d28..fd095e5742c5 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml
> @@ -41,7 +41,7 @@ properties:
> - const: sw3
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description: phandle pointing to the mmio-sram device node
>
> required:
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> index 04b2328903ca..358759fad8dc 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> @@ -84,13 +84,9 @@ properties:
> maxItems: 64
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> minItems: 1
> maxItems: 4
> - items:
> - maxItems: 1
> - description: |
> - phandles to one or more reserved on-chip SRAM regions.
> + description:
> phandle to the On Chip Memory (OCMEM) that's present on some a3xx and
> a4xx Snapdragon SoCs. See
> Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
> diff --git a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
> index 607da11e7baa..d8f92838f4c9 100644
> --- a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
> +++ b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
> @@ -136,13 +136,9 @@ properties:
> maxItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> - description: A phandle array with inner size 1 (no arg cells).
> - First phandle is the LCPA (Logical Channel Parameter Address) memory.
> - Second phandle is the LCLA (Logical Channel Link base Address) memory.
> - maxItems: 2
> items:
> - maxItems: 1
> + - description: LCPA (Logical Channel Parameter Address) memory.
> + - description: LCLA (Logical Channel Link base Address) memory.
>
> memcpy-channels:
> $ref: /schemas/types.yaml#/definitions/uint32-array
> diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> index 6a11c1d11fb5..6cd33dfd095d 100644
> --- a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> +++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> @@ -37,7 +37,7 @@ properties:
> maxItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> The VPU uses the SRAM to store some of the reference data instead of
> storing it on DMA memory. It is mainly used for the purpose of reducing
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 18cc6315a821..6ba668aa633d 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -56,10 +56,10 @@ properties:
> maxItems: 5 # Wrapper and 4 slots
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> - Optional phandle to a reserved on-chip SRAM regions. The SRAM can
> - be used for descriptor storage, which may improve bus utilization.
> + The SRAM can be used for descriptor storage, which may improve bus
> + utilization.
>
> required:
> - compatible
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 42022401d0ff..4f38a0ef29d8 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -91,9 +91,8 @@ properties:
> maxItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description: |
> - phandle to a reserved on-chip SRAM regions.
> + maxItems: 1
> + description:
> Some SoCs, like rk3588 provide on-chip SRAM to store temporary
> buffers during decoding.
>
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> index d9fbb90b0977..7c2ddd27780f 100644
> --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> @@ -47,10 +47,10 @@ properties:
> maxItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> - phandle to a reserved SRAM region which is used as temporary
> - storage memory between DMA and MDMA engines.
> + SRAM region which is used as temporary storage memory between DMA and
> + MDMA engines.
>
> port:
> $ref: /schemas/graph.yaml#/$defs/port-base
> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> index cc346946291a..6bbd83c6aaf7 100644
> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> @@ -67,8 +67,7 @@ properties:
> - const: ppe
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description: phandle to mmio SRAM
> + maxItems: 1
>
> mediatek,ethsys:
> $ref: /schemas/types.yaml#/definitions/phandle
> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> index c296e5711848..883033b19b8f 100644
> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> @@ -21,7 +21,7 @@ properties:
> - ti,am654-sr1-icssg-prueth # for AM65x SoC family, SR1.0
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> phandle to MSMC SRAM node
>
> diff --git a/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
> index a98ad45ca66f..9370c43bc66a 100644
> --- a/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
> @@ -24,7 +24,7 @@ properties:
> - ti,am3359-prueth # for AM33x SoC family
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> phandle to OCMC SRAM node
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml b/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml
> index 76e8ca44906a..3f710433e937 100644
> --- a/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml
> @@ -48,12 +48,7 @@ properties:
> minItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description:
> - phandles to a reserved SRAM region which is used as the memory of
> - the ARC core. The region should be defined as child nodes of the
> - AHB SRAM node as per the generic bindings in
> - Documentation/devicetree/bindings/sram/sram.yaml
> + maxItems: 1
>
> amlogic,secbus2:
> $ref: /schemas/types.yaml#/definitions/phandle
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index b51bb863d759..8b1ed384ef22 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -75,16 +75,8 @@ properties:
> # --------------------
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> minItems: 1
> maxItems: 4
> - items:
> - maxItems: 1
> - description: |
> - phandles to one or more reserved on-chip SRAM regions. The regions
> - should be defined as child nodes of the respective SRAM node, and
> - should be defined as per the generic bindings in,
> - Documentation/devicetree/bindings/sram/sram.yaml
>
> allOf:
> - if:
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> index 775e9b3a1938..14e6b2f817b3 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> @@ -224,16 +224,8 @@ patternProperties:
> at 0x0) or 0 (BTCM at 0x0), default value is 1 if omitted.
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> minItems: 1
> maxItems: 4
> - items:
> - maxItems: 1
> - description: |
> - phandles to one or more reserved on-chip SRAM regions. The regions
> - should be defined as child nodes of the respective SRAM node, and
> - should be defined as per the generic bindings in,
> - Documentation/devicetree/bindings/sram/sram.yaml
>
> required:
> - compatible
> diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> index ee63c03949c9..c7d5e58330d6 100644
> --- a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> @@ -106,20 +106,13 @@ patternProperties:
> - const: rx
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> minItems: 1
> maxItems: 8
> - items:
> - maxItems: 1
> - description: |
> + description:
> phandles to one or more reserved on-chip SRAM regions. Other than TCM,
> the RPU can execute instructions and access data from the OCM memory,
> the main DDR memory, and other system memories.
>
> - The regions should be defined as child nodes of the respective SRAM
> - node, and should be defined as per the generic bindings in
> - Documentation/devicetree/bindings/sram/sram.yaml
> -
> memory-region:
> description: |
> List of phandles to the reserved memory regions associated with the
> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> index 472e92974714..6d7d595e4ab3 100644
> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> @@ -89,12 +89,10 @@ properties:
> - const: rxm2m
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description: |
> - Phandles to a reserved SRAM region which is used as temporary
> - storage memory between DMA and MDMA engines.
> - The region should be defined as child node of the AHB SRAM node
> - as per the generic bindings in Documentation/devicetree/bindings/sram/sram.yaml
> + maxItems: 1
> + description:
> + SRAM region which is used as temporary storage memory between DMA and
> + MDMA engines.
>
> power-domains:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/sram/sram-consumer.yaml b/Documentation/devicetree/bindings/sram/sram-consumer.yaml
> new file mode 100644
> index 000000000000..f00087bd2879
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sram/sram-consumer.yaml
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sram/sram-consumer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SRAM Consumers
> +
> +maintainers:
> + - Rob Herring <robh@kernel.org>
> +
> +select: true
> +
> +properties:
> + sram:
> + description:
> + Phandles to one or more reserved on-chip SRAM regions. The regions
> + should be defined as child nodes of the respective SRAM node, and
> + should be defined as per the generic bindings in,
> + Documentation/devicetree/bindings/sram/sram.yaml
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + maxItems: 1
> +
> +additionalProperties: true
> +...
> --
> 2.53.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
` (4 preceding siblings ...)
2026-05-12 9:15 ` Lorenzo Bianconi
@ 2026-05-13 8:22 ` Vinod Koul
2026-05-13 13:26 ` Dmitry Baryshkov
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Vinod Koul @ 2026-05-13 8:22 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Liu Ying, Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, MD Danish Anwar,
Roger Quadros, Parvathi Pudi, Mohan Reddy Putluru,
Bjorn Andersson, Mathieu Poirier, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Michal Simek, Mark Brown,
Matthias Brugger, AngeloGioacchino Del Regno, Linus Walleij,
Lorenzo Bianconi, Felix Fietkau, Andrew F. Davis, Hussain Khaja,
Suman Anna, Ben Levinsky, Tanmay Shah, Erwan Leray,
Fabrice Gasnier, Roger Quadros, dri-devel, devicetree, imx,
linux-arm-kernel, linux-kernel, linux-arm-msm, freedreno,
dmaengine, linux-media, linux-rockchip, linux-stm32, netdev,
linux-remoteproc, linux-amlogic, linux-spi, linux-mediatek
On 11-05-26, 11:59, Rob Herring (Arm) wrote:
> The "sram" property has become a de facto standard property, so create a
> common schema for it and drop all the duplicated definitions.
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
` (5 preceding siblings ...)
2026-05-13 8:22 ` Vinod Koul
@ 2026-05-13 13:26 ` Dmitry Baryshkov
2026-05-13 17:59 ` Krzysztof Kozlowski
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Dmitry Baryshkov @ 2026-05-13 13:26 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Liu Ying, Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Vinod Koul, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, MD Danish Anwar,
Roger Quadros, Parvathi Pudi, Mohan Reddy Putluru,
Bjorn Andersson, Mathieu Poirier, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Michal Simek, Mark Brown,
Matthias Brugger, AngeloGioacchino Del Regno, Linus Walleij,
Lorenzo Bianconi, Felix Fietkau, Andrew F. Davis, Hussain Khaja,
Suman Anna, Ben Levinsky, Tanmay Shah, Erwan Leray,
Fabrice Gasnier, Roger Quadros, dri-devel, devicetree, imx,
linux-arm-kernel, linux-kernel, linux-arm-msm, freedreno,
dmaengine, linux-media, linux-rockchip, linux-stm32, netdev,
linux-remoteproc, linux-amlogic, linux-spi, linux-mediatek
On Mon, May 11, 2026 at 11:59:36AM -0500, Rob Herring (Arm) wrote:
> The "sram" property has become a de facto standard property, so create a
> common schema for it and drop all the duplicated definitions.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../imx/fsl,imx8qxp-dc-command-sequencer.yaml | 2 +-
> .../devicetree/bindings/display/msm/gpu.yaml | 6 +----
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> # display/msm
> .../bindings/dma/stericsson,dma40.yaml | 8 ++----
> .../bindings/media/cnm,wave521c.yaml | 2 +-
> .../bindings/media/nxp,imx8-jpeg.yaml | 6 ++---
> .../bindings/media/rockchip,vdec.yaml | 5 ++--
> .../bindings/media/st,stm32-dcmi.yaml | 6 ++---
> .../devicetree/bindings/net/mediatek,net.yaml | 3 +--
> .../bindings/net/ti,icssg-prueth.yaml | 2 +-
> .../bindings/net/ti,icssm-prueth.yaml | 2 +-
> .../remoteproc/amlogic,meson-mx-ao-arc.yaml | 7 +----
> .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 8 ------
> .../bindings/remoteproc/ti,k3-r5f-rproc.yaml | 8 ------
> .../remoteproc/xlnx,zynqmp-r5fss.yaml | 9 +------
> .../devicetree/bindings/spi/st,stm32-spi.yaml | 10 +++----
> .../bindings/sram/sram-consumer.yaml | 26 +++++++++++++++++++
> 16 files changed, 48 insertions(+), 62 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sram/sram-consumer.yaml
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
` (6 preceding siblings ...)
2026-05-13 13:26 ` Dmitry Baryshkov
@ 2026-05-13 17:59 ` Krzysztof Kozlowski
2026-05-14 15:18 ` Shah, Tanmay
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-13 17:59 UTC (permalink / raw)
To: Rob Herring (Arm), Liu Ying, Philipp Zabel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Vinod Koul, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, MD Danish Anwar,
Roger Quadros, Parvathi Pudi, Mohan Reddy Putluru,
Bjorn Andersson, Mathieu Poirier, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Michal Simek, Mark Brown,
Matthias Brugger, AngeloGioacchino Del Regno, Linus Walleij,
Lorenzo Bianconi, Felix Fietkau, Andrew F. Davis, Hussain Khaja,
Suman Anna, Ben Levinsky, Tanmay Shah, Erwan Leray,
Fabrice Gasnier
Cc: Roger Quadros, dri-devel, devicetree, imx, linux-arm-kernel,
linux-kernel, linux-arm-msm, freedreno, dmaengine, linux-media,
linux-rockchip, linux-stm32, netdev, linux-remoteproc,
linux-amlogic, linux-spi, linux-mediatek
On 11/05/2026 18:59, Rob Herring (Arm) wrote:
> The "sram" property has become a de facto standard property, so create a
> common schema for it and drop all the duplicated definitions.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
` (7 preceding siblings ...)
2026-05-13 17:59 ` Krzysztof Kozlowski
@ 2026-05-14 15:18 ` Shah, Tanmay
2026-05-16 4:53 ` Claude review: " Claude Code Review Bot
2026-05-16 4:53 ` Claude Code Review Bot
10 siblings, 0 replies; 12+ messages in thread
From: Shah, Tanmay @ 2026-05-14 15:18 UTC (permalink / raw)
To: Rob Herring (Arm), Liu Ying, Philipp Zabel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, Vinod Koul, Nas Chung, Jackson Lee,
Mauro Carvalho Chehab, Mirela Rabulea, Detlev Casanova,
Ezequiel Garcia, Heiko Stuebner, Hugues Fruchet, Alain Volmat,
Maxime Coquelin, Alexandre Torgue, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, MD Danish Anwar,
Roger Quadros, Parvathi Pudi, Mohan Reddy Putluru,
Bjorn Andersson, Mathieu Poirier, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Michal Simek, Mark Brown,
Matthias Brugger, AngeloGioacchino Del Regno, Linus Walleij,
Lorenzo Bianconi, Felix Fietkau, Andrew F. Davis, Hussain Khaja,
Suman Anna, Ben Levinsky, Tanmay Shah, Erwan Leray,
Fabrice Gasnier
Cc: Roger Quadros, dri-devel, devicetree, imx, linux-arm-kernel,
linux-kernel, linux-arm-msm, freedreno, dmaengine, linux-media,
linux-rockchip, linux-stm32, netdev, linux-remoteproc,
linux-amlogic, linux-spi, linux-mediatek
Reviewed-by: Tanmay Shah <tanmay.shah@amd.com>
On 5/11/2026 11:59 AM, Rob Herring (Arm) wrote:
> The "sram" property has become a de facto standard property, so create a
> common schema for it and drop all the duplicated definitions.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../imx/fsl,imx8qxp-dc-command-sequencer.yaml | 2 +-
> .../devicetree/bindings/display/msm/gpu.yaml | 6 +----
> .../bindings/dma/stericsson,dma40.yaml | 8 ++----
> .../bindings/media/cnm,wave521c.yaml | 2 +-
> .../bindings/media/nxp,imx8-jpeg.yaml | 6 ++---
> .../bindings/media/rockchip,vdec.yaml | 5 ++--
> .../bindings/media/st,stm32-dcmi.yaml | 6 ++---
> .../devicetree/bindings/net/mediatek,net.yaml | 3 +--
> .../bindings/net/ti,icssg-prueth.yaml | 2 +-
> .../bindings/net/ti,icssm-prueth.yaml | 2 +-
> .../remoteproc/amlogic,meson-mx-ao-arc.yaml | 7 +----
> .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 8 ------
> .../bindings/remoteproc/ti,k3-r5f-rproc.yaml | 8 ------
> .../remoteproc/xlnx,zynqmp-r5fss.yaml | 9 +------
> .../devicetree/bindings/spi/st,stm32-spi.yaml | 10 +++----
> .../bindings/sram/sram-consumer.yaml | 26 +++++++++++++++++++
> 16 files changed, 48 insertions(+), 62 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sram/sram-consumer.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml
> index 27118f4c0d28..fd095e5742c5 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-command-sequencer.yaml
> @@ -41,7 +41,7 @@ properties:
> - const: sw3
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description: phandle pointing to the mmio-sram device node
>
> required:
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> index 04b2328903ca..358759fad8dc 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> @@ -84,13 +84,9 @@ properties:
> maxItems: 64
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> minItems: 1
> maxItems: 4
> - items:
> - maxItems: 1
> - description: |
> - phandles to one or more reserved on-chip SRAM regions.
> + description:
> phandle to the On Chip Memory (OCMEM) that's present on some a3xx and
> a4xx Snapdragon SoCs. See
> Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
> diff --git a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
> index 607da11e7baa..d8f92838f4c9 100644
> --- a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
> +++ b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
> @@ -136,13 +136,9 @@ properties:
> maxItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> - description: A phandle array with inner size 1 (no arg cells).
> - First phandle is the LCPA (Logical Channel Parameter Address) memory.
> - Second phandle is the LCLA (Logical Channel Link base Address) memory.
> - maxItems: 2
> items:
> - maxItems: 1
> + - description: LCPA (Logical Channel Parameter Address) memory.
> + - description: LCLA (Logical Channel Link base Address) memory.
>
> memcpy-channels:
> $ref: /schemas/types.yaml#/definitions/uint32-array
> diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> index 6a11c1d11fb5..6cd33dfd095d 100644
> --- a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> +++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> @@ -37,7 +37,7 @@ properties:
> maxItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> The VPU uses the SRAM to store some of the reference data instead of
> storing it on DMA memory. It is mainly used for the purpose of reducing
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 18cc6315a821..6ba668aa633d 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -56,10 +56,10 @@ properties:
> maxItems: 5 # Wrapper and 4 slots
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> - Optional phandle to a reserved on-chip SRAM regions. The SRAM can
> - be used for descriptor storage, which may improve bus utilization.
> + The SRAM can be used for descriptor storage, which may improve bus
> + utilization.
>
> required:
> - compatible
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 42022401d0ff..4f38a0ef29d8 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -91,9 +91,8 @@ properties:
> maxItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description: |
> - phandle to a reserved on-chip SRAM regions.
> + maxItems: 1
> + description:
> Some SoCs, like rk3588 provide on-chip SRAM to store temporary
> buffers during decoding.
>
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> index d9fbb90b0977..7c2ddd27780f 100644
> --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> @@ -47,10 +47,10 @@ properties:
> maxItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> - phandle to a reserved SRAM region which is used as temporary
> - storage memory between DMA and MDMA engines.
> + SRAM region which is used as temporary storage memory between DMA and
> + MDMA engines.
>
> port:
> $ref: /schemas/graph.yaml#/$defs/port-base
> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> index cc346946291a..6bbd83c6aaf7 100644
> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> @@ -67,8 +67,7 @@ properties:
> - const: ppe
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description: phandle to mmio SRAM
> + maxItems: 1
>
> mediatek,ethsys:
> $ref: /schemas/types.yaml#/definitions/phandle
> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> index c296e5711848..883033b19b8f 100644
> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> @@ -21,7 +21,7 @@ properties:
> - ti,am654-sr1-icssg-prueth # for AM65x SoC family, SR1.0
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> phandle to MSMC SRAM node
>
> diff --git a/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
> index a98ad45ca66f..9370c43bc66a 100644
> --- a/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
> @@ -24,7 +24,7 @@ properties:
> - ti,am3359-prueth # for AM33x SoC family
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> description:
> phandle to OCMC SRAM node
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml b/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml
> index 76e8ca44906a..3f710433e937 100644
> --- a/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/amlogic,meson-mx-ao-arc.yaml
> @@ -48,12 +48,7 @@ properties:
> minItems: 1
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description:
> - phandles to a reserved SRAM region which is used as the memory of
> - the ARC core. The region should be defined as child nodes of the
> - AHB SRAM node as per the generic bindings in
> - Documentation/devicetree/bindings/sram/sram.yaml
> + maxItems: 1
>
> amlogic,secbus2:
> $ref: /schemas/types.yaml#/definitions/phandle
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index b51bb863d759..8b1ed384ef22 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -75,16 +75,8 @@ properties:
> # --------------------
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> minItems: 1
> maxItems: 4
> - items:
> - maxItems: 1
> - description: |
> - phandles to one or more reserved on-chip SRAM regions. The regions
> - should be defined as child nodes of the respective SRAM node, and
> - should be defined as per the generic bindings in,
> - Documentation/devicetree/bindings/sram/sram.yaml
>
> allOf:
> - if:
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> index 775e9b3a1938..14e6b2f817b3 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> @@ -224,16 +224,8 @@ patternProperties:
> at 0x0) or 0 (BTCM at 0x0), default value is 1 if omitted.
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> minItems: 1
> maxItems: 4
> - items:
> - maxItems: 1
> - description: |
> - phandles to one or more reserved on-chip SRAM regions. The regions
> - should be defined as child nodes of the respective SRAM node, and
> - should be defined as per the generic bindings in,
> - Documentation/devicetree/bindings/sram/sram.yaml
>
> required:
> - compatible
> diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> index ee63c03949c9..c7d5e58330d6 100644
> --- a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> @@ -106,20 +106,13 @@ patternProperties:
> - const: rx
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> minItems: 1
> maxItems: 8
> - items:
> - maxItems: 1
> - description: |
> + description:
> phandles to one or more reserved on-chip SRAM regions. Other than TCM,
> the RPU can execute instructions and access data from the OCM memory,
> the main DDR memory, and other system memories.
>
> - The regions should be defined as child nodes of the respective SRAM
> - node, and should be defined as per the generic bindings in
> - Documentation/devicetree/bindings/sram/sram.yaml
> -
> memory-region:
> description: |
> List of phandles to the reserved memory regions associated with the
> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> index 472e92974714..6d7d595e4ab3 100644
> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> @@ -89,12 +89,10 @@ properties:
> - const: rxm2m
>
> sram:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description: |
> - Phandles to a reserved SRAM region which is used as temporary
> - storage memory between DMA and MDMA engines.
> - The region should be defined as child node of the AHB SRAM node
> - as per the generic bindings in Documentation/devicetree/bindings/sram/sram.yaml
> + maxItems: 1
> + description:
> + SRAM region which is used as temporary storage memory between DMA and
> + MDMA engines.
>
> power-domains:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/sram/sram-consumer.yaml b/Documentation/devicetree/bindings/sram/sram-consumer.yaml
> new file mode 100644
> index 000000000000..f00087bd2879
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sram/sram-consumer.yaml
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sram/sram-consumer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SRAM Consumers
> +
> +maintainers:
> + - Rob Herring <robh@kernel.org>
> +
> +select: true
> +
> +properties:
> + sram:
> + description:
> + Phandles to one or more reserved on-chip SRAM regions. The regions
> + should be defined as child nodes of the respective SRAM node, and
> + should be defined as per the generic bindings in,
> + Documentation/devicetree/bindings/sram/sram.yaml
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + maxItems: 1
> +
> +additionalProperties: true
> +...
^ permalink raw reply [flat|nested] 12+ messages in thread
* Claude review: dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
` (8 preceding siblings ...)
2026-05-14 15:18 ` Shah, Tanmay
@ 2026-05-16 4:53 ` Claude Code Review Bot
2026-05-16 4:53 ` Claude Code Review Bot
10 siblings, 0 replies; 12+ messages in thread
From: Claude Code Review Bot @ 2026-05-16 4:53 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: dt-bindings: Consolidate "sram" property definition
Author: "Rob Herring (Arm)" <robh@kernel.org>
Patches: 10
Reviewed: 2026-05-16T14:53:56.864908
---
This is a single patch from Rob Herring (DT binding maintainer) that creates a common `sram-consumer.yaml` schema using the well-established `select: true` consumer pattern (already used by nvmem-consumer, leds-consumer, mux-consumer, etc.) and removes the duplicated `sram` property definitions from 15 individual binding files.
The approach is sound and follows established dt-bindings conventions. The common schema defines `sram` as a `phandle-array` with `items: maxItems: 1` (no arg cells), while device-specific schemas retain their own `minItems`/`maxItems` constraints and device-specific descriptions. The files that previously defined `sram` as a plain `phandle` (single entry) are compatible with the `phandle-array` definition since they retain `maxItems: 1`.
Overall this is a straightforward de-duplication cleanup. One minor concern worth raising is noted below.
**Verdict: Looks good. One minor question on the stericsson DMA40 change.**
---
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 12+ messages in thread
* Claude review: dt-bindings: Consolidate "sram" property definition
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
` (9 preceding siblings ...)
2026-05-16 4:53 ` Claude review: " Claude Code Review Bot
@ 2026-05-16 4:53 ` Claude Code Review Bot
10 siblings, 0 replies; 12+ messages in thread
From: Claude Code Review Bot @ 2026-05-16 4:53 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**New file: `sram-consumer.yaml`**
The new common schema is clean and follows the established pattern:
```yaml
select: true
properties:
sram:
description:
Phandles to one or more reserved on-chip SRAM regions...
$ref: /schemas/types.yaml#/definitions/phandle-array
items:
maxItems: 1
additionalProperties: true
```
This is consistent with how `nvmem-consumer.yaml`, `leds-consumer.yaml`, and similar schemas are structured. No issues.
**Single-phandle consumers (imx8qxp-dc, cnm-wave521c, nxp-imx8-jpeg, mediatek-net, ti-icssg-prueth, ti-icssm-prueth, stm32-dcmi, rockchip-vdec, stm32-spi, amlogic-meson-mx-ao-arc)**
These all follow the same pattern — removing `$ref: /schemas/types.yaml#/definitions/phandle` and replacing with (or keeping) `maxItems: 1`. Since the common schema now provides the type definition as `phandle-array`, and `maxItems: 1` constrains it to a single entry, validation behavior is preserved. The description cleanups (removing generic "phandle to SRAM" boilerplate) are appropriate since the common schema now carries the generic description.
No issues with any of these.
**Multi-phandle consumers (msm/gpu.yaml, ti-k3-dsp-rproc, ti-k3-r5f-rproc, xlnx-zynqmp-r5fss)**
These remove `$ref: /schemas/types.yaml#/definitions/phandle-array` and `items: maxItems: 1`, keeping only `minItems`/`maxItems` constraints and device-specific descriptions. The common schema now provides the type and inner-item constraint. Correct.
**stericsson,dma40.yaml — minor concern**
This change is slightly different from the others:
```yaml
# Before:
sram:
$ref: /schemas/types.yaml#/definitions/phandle-array
description: A phandle array with inner size 1 (no arg cells).
First phandle is the LCPA ...
Second phandle is the LCLA ...
maxItems: 2
items:
maxItems: 1
# After:
sram:
items:
- description: LCPA (Logical Channel Parameter Address) memory.
- description: LCLA (Logical Channel Link base Address) memory.
```
The explicit `maxItems: 2` is removed, relying on the two-element tuple-style `items` list to implicitly set it. This works correctly in dt-schema (tuple `items` implicitly constrains the array length). However, unlike the other changes, the after version uses `items` as a tuple (array of schemas) while the common schema uses `items` as a single schema (`items: { maxItems: 1 }`). Both forms are valid and non-conflicting in JSON Schema — the common schema's `items: { maxItems: 1 }` validates that every element has at most 1 cell, and the per-device tuple provides per-position descriptions. But this is the one case where two different `items` forms coexist on the same property from different schemas, which is worth a quick sanity check that dt-schema handles it correctly (it should, but it's the most nuanced change in the series).
**Nit:** The original dma40 description has a double space (`the LCLA`) which is preserved in the new per-item description — not introduced by this patch, so not a concern, but could be fixed opportunistically.
**Summary:** Clean, well-motivated de-duplication following established dt-bindings patterns. The stericsson DMA40 tuple-vs-schema `items` interaction is the only thing worth confirming, but it should work correctly per JSON Schema semantics.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2026-05-16 4:53 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-11 16:59 [PATCH] dt-bindings: Consolidate "sram" property definition Rob Herring (Arm)
2026-05-11 18:55 ` Linus Walleij
2026-05-11 23:09 ` Jakub Kicinski
2026-05-12 0:46 ` Mark Brown
2026-05-12 2:57 ` Liu Ying
2026-05-12 9:15 ` Lorenzo Bianconi
2026-05-13 8:22 ` Vinod Koul
2026-05-13 13:26 ` Dmitry Baryshkov
2026-05-13 17:59 ` Krzysztof Kozlowski
2026-05-14 15:18 ` Shah, Tanmay
2026-05-16 4:53 ` Claude review: " Claude Code Review Bot
2026-05-16 4:53 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox