From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: imx93-mipi-dsi: Fix mode validation
Date: Sat, 16 May 2026 13:49:54 +1000 [thread overview]
Message-ID: <review-overall-20260512-imx93-mipi-dsi-fix-mode-validation-v2-1-7aec3be5da2c@nxp.com> (raw)
In-Reply-To: <20260512-imx93-mipi-dsi-fix-mode-validation-v2-1-7aec3be5da2c@nxp.com>
Overall Series Review
Subject: drm/bridge: imx93-mipi-dsi: Fix mode validation
Author: Liu Ying <victor.liu@nxp.com>
Patches: 2
Reviewed: 2026-05-16T13:49:54.773137
---
This is a single-patch fix for the imx93 MIPI DSI bridge driver's mode validation logic. The bug is real and well-described: the original code checked only the last bridge in the chain for `DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID`, but the last bridge is typically a connector bridge without those ops set. The fix iterates over the bridge chain to find any bridge with those capabilities, which correctly enables the +/-0.5% pixel clock tolerance for EDID-sourced modes.
The patch is clean, correct, and well-explained. The use of `drm_for_each_bridge_in_chain_from()` is appropriate and replaces the manual `drm_bridge_chain_get_last_bridge()` + `__free(drm_bridge_put)` pattern with the iterator's built-in cleanup. **Reviewed-by is appropriate.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 3:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 9:18 [PATCH v2] drm/bridge: imx93-mipi-dsi: Fix mode validation Liu Ying
2026-05-14 5:55 ` Liu Ying
2026-05-16 3:49 ` Claude Code Review Bot [this message]
2026-05-16 3:49 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-15 6:54 [PATCH v3] " Liu Ying
2026-05-15 23:49 ` Claude review: " Claude Code Review Bot
2026-05-15 23:49 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260512-imx93-mipi-dsi-fix-mode-validation-v2-1-7aec3be5da2c@nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox