public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: imx93-mipi-dsi: Fix mode validation
Date: Sat, 16 May 2026 09:49:36 +1000	[thread overview]
Message-ID: <review-overall-20260515-imx93-mipi-dsi-fix-mode-validation-v3-1-91f7d22b2fe4@nxp.com> (raw)
In-Reply-To: <20260515-imx93-mipi-dsi-fix-mode-validation-v3-1-91f7d22b2fe4@nxp.com>

Overall Series Review

Subject: drm/bridge: imx93-mipi-dsi: Fix mode validation
Author: Liu Ying <victor.liu@nxp.com>
Patches: 1
Reviewed: 2026-05-16T09:49:36.532814

---

This is a single-patch fix for mode validation in the i.MX93 MIPI DSI bridge driver. The problem: the old code checked only the **last** bridge in the chain for `DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID`, but when the last bridge is a connector bridge (with no ops set), the check always fails, and the +/-0.5% pixel clock deviation tolerance is never applied. The fix iterates over all bridges after the DSI bridge, looking for the first one that has both ops set.

The patch is well-reasoned and correct. The refcounting is handled properly in all paths (normal exit, early return on `MODE_NOCLOCK`, loop exhaustion). The manual iteration (instead of using `drm_for_each_bridge_in_chain_from()`) is the right approach because `bridge_chain_mutex` is already held by the caller `drm_bridge_chain_mode_valid()` — using the macro would deadlock. This was identified in v2 review and fixed in v3.

**Verdict: Looks good.** One minor observation below but nothing blocking.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-15 23:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15  6:54 [PATCH v3] drm/bridge: imx93-mipi-dsi: Fix mode validation Liu Ying
2026-05-15 23:49 ` Claude Code Review Bot [this message]
2026-05-15 23:49 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12  9:18 [PATCH v2] " Liu Ying
2026-05-16  3:49 ` Claude review: " Claude Code Review Bot
2026-05-16  3:49 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260515-imx93-mipi-dsi-fix-mode-validation-v3-1-91f7d22b2fe4@nxp.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox