From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Add reclaim to the dmem cgroup controller
Date: Sat, 16 May 2026 14:03:59 +1000 [thread overview]
Message-ID: <review-overall-20260512082406.44470-1-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20260512082406.44470-1-thomas.hellstrom@linux.intel.com>
Overall Series Review
Subject: Add reclaim to the dmem cgroup controller
Author: =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= <thomas.hellstrom@linux.intel.com>
Patches: 6
Reviewed: 2026-05-16T14:03:59.614912
---
This is a well-structured v4 series that adds reclaim support to the dmem cgroup controller, enabling `dmem.max` writes below current usage to trigger TTM eviction rather than silently failing. The layering is clean: patch 1 is a standalone bug fix, patch 2 adds the core cgroup infrastructure, patch 3 provides the TTM eviction machinery, and patches 4-5 wire up xe and amdgpu respectively.
The locking design (rwsem protecting reclaim callbacks against concurrent unregister) is sound, signal handling is proper, and the O_NONBLOCK support is a nice touch. The multi-pass eviction strategy in `ttm_bo_evict_cgroup()` correctly mirrors the existing `ttm_bo_evict_alloc()` approach. The series is generally in good shape for v4.
One design consideration worth flagging: partial reclaim progress currently terminates the retry loop rather than retrying with a smaller target, which is conservative but may leave reclaimable memory on the table. This is discussed further in patch 2/3 below.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 4:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 8:24 [PATCH v4 0/5] Add reclaim to the dmem cgroup controller Thomas Hellström
2026-05-12 8:24 ` [PATCH v4 1/5] drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init() Thomas Hellström
2026-05-16 4:03 ` Claude review: " Claude Code Review Bot
2026-05-12 8:24 ` [PATCH v4 2/5] cgroup/dmem: Add reclaim callback for lowering max below current usage Thomas Hellström
2026-05-16 4:04 ` Claude review: " Claude Code Review Bot
2026-05-12 8:24 ` [PATCH v4 3/5] drm/ttm: Hook up a cgroup-aware reclaim callback for the dmem controller Thomas Hellström
2026-05-16 4:04 ` Claude review: " Claude Code Review Bot
2026-05-12 8:24 ` [PATCH v4 4/5] drm/xe: Wire up dmem cgroup reclaim for VRAM manager Thomas Hellström
2026-05-16 4:04 ` Claude review: " Claude Code Review Bot
2026-05-12 8:24 ` [PATCH v4 5/5] drm/amdgpu: " Thomas Hellström
2026-05-16 4:04 ` Claude review: " Claude Code Review Bot
2026-05-16 4:03 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-11 17:30 [PATCH v3 0/5] Add reclaim to the dmem cgroup controller Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260512082406.44470-1-thomas.hellstrom@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox