public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: Wire up dmem cgroup reclaim for VRAM manager
Date: Sat, 16 May 2026 14:04:01 +1000	[thread overview]
Message-ID: <review-patch5-20260512082406.44470-6-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20260512082406.44470-6-thomas.hellstrom@linux.intel.com>

Patch Review

**Verdict: Good, with one observation on the NULL place guard.**

**NULL place guard in `amdgpu_ttm_bo_eviction_valuable`:**

```c
 		if (amdkfd_fence_check_mm(f, current->mm) &&
-		    !(place->flags & TTM_PL_FLAG_CONTIGUOUS))
+		    !(place && (place->flags & TTM_PL_FLAG_CONTIGUOUS)))
 			return false;
```

When `place` is NULL (cgroup drain mode), `!(place && ...)` evaluates to `true`, so the condition becomes `amdkfd_fence_check_mm(f, current->mm) && true` → returns `false` (BO not evictable). This means KFD BOs belonging to `current->mm` are protected from cgroup reclaim.

In practice this is likely fine: the cgroup `max` write is typically done by a cgroup management process (systemd, container runtime), not by the KFD process itself, so `amdkfd_fence_check_mm(f, current->mm)` would be false and the check would pass. The conservative behavior (protect KFD BOs from the writing process) is the safe choice here.

**Cgroup registration wiring** mirrors patch 4 and uses the same `ttm_resource_manager_set_dmem_region` helper. Clean.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  4:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  8:24 [PATCH v4 0/5] Add reclaim to the dmem cgroup controller Thomas Hellström
2026-05-12  8:24 ` [PATCH v4 1/5] drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init() Thomas Hellström
2026-05-16  4:03   ` Claude review: " Claude Code Review Bot
2026-05-12  8:24 ` [PATCH v4 2/5] cgroup/dmem: Add reclaim callback for lowering max below current usage Thomas Hellström
2026-05-16  4:04   ` Claude review: " Claude Code Review Bot
2026-05-12  8:24 ` [PATCH v4 3/5] drm/ttm: Hook up a cgroup-aware reclaim callback for the dmem controller Thomas Hellström
2026-05-16  4:04   ` Claude review: " Claude Code Review Bot
2026-05-12  8:24 ` [PATCH v4 4/5] drm/xe: Wire up dmem cgroup reclaim for VRAM manager Thomas Hellström
2026-05-16  4:04   ` Claude review: " Claude Code Review Bot
2026-05-12  8:24 ` [PATCH v4 5/5] drm/amdgpu: " Thomas Hellström
2026-05-16  4:04   ` Claude Code Review Bot [this message]
2026-05-16  4:03 ` Claude review: Add reclaim to the dmem cgroup controller Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11 17:30 [PATCH v3 0/5] " Thomas Hellström
2026-05-11 17:30 ` [PATCH v3 5/5] drm/amdgpu: Wire up dmem cgroup reclaim for VRAM manager Thomas Hellström
2026-05-16  4:48   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260512082406.44470-6-thomas.hellstrom@linux.intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox