From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init()
Date: Sat, 16 May 2026 14:03:59 +1000 [thread overview]
Message-ID: <review-patch1-20260512082406.44470-2-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20260512082406.44470-2-thomas.hellstrom@linux.intel.com>
Patch Review
**Verdict: Good. Straightforward correctness fix.**
The commit message clearly explains the crash: `drmm_cgroup_register_region()` was called before `INIT_LIST_HEAD()` and `gpu_buddy_init()`, so a registration failure left the lists zero-initialized (not empty) and the buddy allocator uninitialized, causing NULL dereferences in `amdgpu_vram_mgr_fini()`.
The fix correctly moves the cgroup registration after the list and buddy allocator initialization:
```c
+ man->cg = drmm_cgroup_register_region(adev_to_drm(adev), "vram", adev->gmc.real_vram_size);
+ if (IS_ERR(man->cg))
+ return PTR_ERR(man->cg);
```
Now placed after `gpu_buddy_init()` succeeds, so the teardown path can safely iterate the lists and call `gpu_buddy_fini()`. The Fixes/Cc-stable tags are appropriate. No issues.
Note: Patch 5 replaces this exact code with the new `ttm_resource_manager_set_dmem_region()` helper, so patch 1 exists as a standalone backportable fix for stable kernels. This split is correct.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 4:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 8:24 [PATCH v4 0/5] Add reclaim to the dmem cgroup controller Thomas Hellström
2026-05-12 8:24 ` [PATCH v4 1/5] drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init() Thomas Hellström
2026-05-16 4:03 ` Claude Code Review Bot [this message]
2026-05-12 8:24 ` [PATCH v4 2/5] cgroup/dmem: Add reclaim callback for lowering max below current usage Thomas Hellström
2026-05-16 4:04 ` Claude review: " Claude Code Review Bot
2026-05-12 8:24 ` [PATCH v4 3/5] drm/ttm: Hook up a cgroup-aware reclaim callback for the dmem controller Thomas Hellström
2026-05-16 4:04 ` Claude review: " Claude Code Review Bot
2026-05-12 8:24 ` [PATCH v4 4/5] drm/xe: Wire up dmem cgroup reclaim for VRAM manager Thomas Hellström
2026-05-16 4:04 ` Claude review: " Claude Code Review Bot
2026-05-12 8:24 ` [PATCH v4 5/5] drm/amdgpu: " Thomas Hellström
2026-05-16 4:04 ` Claude review: " Claude Code Review Bot
2026-05-16 4:03 ` Claude review: Add reclaim to the dmem cgroup controller Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-11 17:30 [PATCH v3 0/5] " Thomas Hellström
2026-05-11 17:30 ` [PATCH v3 1/5] drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init() Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260512082406.44470-2-thomas.hellstrom@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox