From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init()
Date: Sat, 16 May 2026 14:48:42 +1000 [thread overview]
Message-ID: <review-patch1-20260511173008.36526-2-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20260511173008.36526-2-thomas.hellstrom@linux.intel.com>
Patch Review
**Verdict: Good, correct fix.**
The bug is real and well described. In the current code at `amdgpu_vram_mgr.c:921`, `drmm_cgroup_register_region()` is called before `INIT_LIST_HEAD()` (lines 928-930) and `gpu_buddy_init()` (line 934). If registration fails, `adev->mman.initialized` is already true, so teardown calls `amdgpu_vram_mgr_fini()` which dereferences NULL list head pointers and uninitialized buddy allocator state.
The fix correctly moves registration to after all initialization. If registration fails at the new location, the buddy allocator and lists are properly initialized, so `amdgpu_vram_mgr_fini()` can safely clean them up.
The `Cc: stable` tag for v6.14+ is appropriate since the bug was introduced by commit `2b624a2c1865`.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 4:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 17:30 [PATCH v3 0/5] Add reclaim to the dmem cgroup controller Thomas Hellström
2026-05-11 17:30 ` [PATCH v3 1/5] drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init() Thomas Hellström
2026-05-16 4:48 ` Claude Code Review Bot [this message]
2026-05-11 17:30 ` [PATCH v3 2/5] cgroup/dmem: Add reclaim callback for lowering max below current usage Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
2026-05-11 17:30 ` [PATCH v3 3/5] drm/ttm: Hook up a cgroup-aware reclaim callback for the dmem controller Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
2026-05-11 17:30 ` [PATCH v3 4/5] drm/xe: Wire up dmem cgroup reclaim for VRAM manager Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
2026-05-11 17:30 ` [PATCH v3 5/5] drm/amdgpu: " Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
2026-05-16 4:48 ` Claude review: Add reclaim to the dmem cgroup controller Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-12 8:24 [PATCH v4 0/5] " Thomas Hellström
2026-05-12 8:24 ` [PATCH v4 1/5] drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init() Thomas Hellström
2026-05-16 4:03 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260511173008.36526-2-thomas.hellstrom@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox