From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: Wire up dmem cgroup reclaim for VRAM manager
Date: Sat, 16 May 2026 14:48:43 +1000 [thread overview]
Message-ID: <review-patch5-20260511173008.36526-6-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20260511173008.36526-6-thomas.hellstrom@linux.intel.com>
Patch Review
**Verdict: Good.**
Two changes:
1. Routes cgroup registration through `ttm_resource_manager_set_dmem_region()`, using a local `cg` variable instead of directly assigning to `man->cg`. This prevents storing error pointers in `man->cg` (the v3 fix).
2. The NULL place guard in `amdgpu_ttm_bo_eviction_valuable()`:
```c
- !(place->flags & TTM_PL_FLAG_CONTIGUOUS))
+ !(place && (place->flags & TTM_PL_FLAG_CONTIGUOUS)))
```
When `place` is NULL (cgroup drain mode), this expression evaluates to `!(NULL)` which is `true`, so the KFD fence check can still return `false` (preventing eviction of same-process KFD BOs). This seems like the right behavior: in cgroup drain mode, KFD BOs that belong to the current process are still protected from eviction unless the placement requires contiguous memory (which can't be determined without a place). This is a conservative and safe choice.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 4:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 17:30 [PATCH v3 0/5] Add reclaim to the dmem cgroup controller Thomas Hellström
2026-05-11 17:30 ` [PATCH v3 1/5] drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init() Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
2026-05-11 17:30 ` [PATCH v3 2/5] cgroup/dmem: Add reclaim callback for lowering max below current usage Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
2026-05-11 17:30 ` [PATCH v3 3/5] drm/ttm: Hook up a cgroup-aware reclaim callback for the dmem controller Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
2026-05-11 17:30 ` [PATCH v3 4/5] drm/xe: Wire up dmem cgroup reclaim for VRAM manager Thomas Hellström
2026-05-16 4:48 ` Claude review: " Claude Code Review Bot
2026-05-11 17:30 ` [PATCH v3 5/5] drm/amdgpu: " Thomas Hellström
2026-05-16 4:48 ` Claude Code Review Bot [this message]
2026-05-16 4:48 ` Claude review: Add reclaim to the dmem cgroup controller Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-12 8:24 [PATCH v4 0/5] " Thomas Hellström
2026-05-12 8:24 ` [PATCH v4 5/5] drm/amdgpu: Wire up dmem cgroup reclaim for VRAM manager Thomas Hellström
2026-05-16 4:04 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260511173008.36526-6-thomas.hellstrom@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox