From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Revert "i915: don't use a vma that didn't match the context VM"
Date: Sat, 16 May 2026 13:59:28 +1000 [thread overview]
Message-ID: <review-overall-20260512085848.208008-1-joonas.lahtinen@linux.intel.com> (raw)
In-Reply-To: <20260512085848.208008-1-joonas.lahtinen@linux.intel.com>
Overall Series Review
Subject: Revert "i915: don't use a vma that didn't match the context VM"
Author: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Patches: 2
Reviewed: 2026-05-16T13:59:28.286020
---
This is a single-patch revert of commit `5401b9adebc9`, which had added an explicit `else vma = NULL` branch to `eb_lookup_vma()`. The patch is correct: the removed code is indeed a no-op, and the revert is clean and well-justified.
**Verdict: Looks good.**
The `radix_tree_lookup()` function already returns `NULL` when the key is not found, so the `else vma = NULL` assignment is redundant — `vma` is already `NULL` in that branch. The only remaining question is whether the explicit assignment served a defensive/clarity purpose, but as the commit message explains (with a link to the Linus discussion), the original commit was motivated by a UAF concern that hasn't been possible since 2021. Removing dead defensive code that was added under a false premise is reasonable.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 8:58 [PATCH] Revert "i915: don't use a vma that didn't match the context VM" Joonas Lahtinen
2026-05-12 15:15 ` Linus Torvalds
2026-05-16 3:59 ` Claude Code Review Bot [this message]
2026-05-16 3:59 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260512085848.208008-1-joonas.lahtinen@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox