From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Revert "i915: don't use a vma that didn't match the context VM"
Date: Sat, 16 May 2026 13:59:28 +1000 [thread overview]
Message-ID: <review-patch1-20260512085848.208008-1-joonas.lahtinen@linux.intel.com> (raw)
In-Reply-To: <20260512085848.208008-1-joonas.lahtinen@linux.intel.com>
Patch Review
**Correctness: OK**
The patch removes:
```c
else
vma = NULL;
```
from the `eb_lookup_vma()` function in `i915_gem_execbuffer.c`.
This is correct because:
1. `radix_tree_lookup()` returns `void *` and yields `NULL` when the entry is not found (declared in `include/linux/radix-tree.h`). So when the `if (likely(vma))` test falls through, `vma` is already `NULL`.
2. `i915_vma_tryget()` (defined in `i915_vma.h:194`) also returns `NULL` on failure (when `kref_get_unless_zero` fails), so even after the `if (likely(vma))` → `i915_vma_tryget(vma)` path, a failure still leaves `vma` as `NULL`.
3. After the removed `else` branch, the code proceeds to `if (likely(vma)) return vma;` — which correctly handles the `NULL` case regardless.
**Commit message: Good.** References the original commit hash, links the relevant lore discussion with Linus, and explains why the original commit was a no-op. The Cc list is appropriate — includes the original participants in the discussion.
**Style: Fine.** A straightforward revert with `git revert` formatting.
**No concerns.** This is a clean, well-justified removal of dead code.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 8:58 [PATCH] Revert "i915: don't use a vma that didn't match the context VM" Joonas Lahtinen
2026-05-12 15:15 ` Linus Torvalds
2026-05-16 3:59 ` Claude Code Review Bot [this message]
2026-05-16 3:59 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260512085848.208008-1-joonas.lahtinen@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox