public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tidss: Add BeagleY-AI display support (and some more)
Date: Sat, 16 May 2026 12:00:14 +1000	[thread overview]
Message-ID: <review-overall-20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com> (raw)
In-Reply-To: <20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com>

Overall Series Review

Subject: drm/tidss: Add BeagleY-AI display support (and some more)
Author: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Patches: 23
Reviewed: 2026-05-16T12:00:14.716115

---

This is a well-structured 16-patch series from Tomi Valkeinen adding display support for the BeagleY-AI board (TI AM62P/J722S SoCs). The series covers DT bindings, driver changes, and board DTS. The main highlights:

1. **DT binding refactoring** (patches 1-5): Splits AM62L into its own binding file, simplifies the AM65x binding, adds OLDI power-domain, adds `ti,dpi-io-ctrl` for signal edge config, and adds AM62P DSS compatible.

2. **Driver cleanups** (patches 6-7): Removes redundant `pm_runtime_mark_last_busy` and unused OLDI register define.

3. **DPI detection and signal edge support** (patches 8-10): Adds mechanism to detect DPI output, configures external DPI0_CLK_CTRL register via syscon, and adds DPIENABLE bit support for power savings.

4. **OLDI fixes and aux driver conversion** (patches 11-12): Fixes signal polarity handling, then converts OLDI to auxiliary device/driver for proper power-domain management.

5. **AM62P support and board DTS** (patches 13-16): Adds AM62P compatible, makes main_conf a syscon, adds DSS/OLDI/DSI/DPHY nodes, enables HDMI on BeagleY-AI.

Overall the series is solid work with good commit messages explaining the "why". Most DT binding patches already have Rob's Reviewed-by. A few issues worth addressing are noted below.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  2:00 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 13:17 [PATCH v2 00/16] drm/tidss: Add BeagleY-AI display support (and some more) Tomi Valkeinen
2026-05-13 13:17 ` [PATCH v2 01/16] dt-bindings: display: ti: Move ti,am62l-dss binding to a new binding file Tomi Valkeinen
2026-05-15  6:51   ` Krzysztof Kozlowski
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 02/16] dt-bindings: display: ti,am65x-dss: Simplify binding Tomi Valkeinen
2026-05-15  6:51   ` Krzysztof Kozlowski
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 03/16] dt-bindings: display: ti,am625-oldi: Add optional power-domain for OLDI Tomi Valkeinen
2026-05-15  6:51   ` Krzysztof Kozlowski
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 04/16] dt-bindings: display: ti,am65x-dss: Add ti,dpi-io-ctrl Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 05/16] dt-bindings: display: ti,am65x-dss: Add AM62P DSS Tomi Valkeinen
2026-05-15  6:52   ` Krzysztof Kozlowski
2026-05-15  6:56     ` Tomi Valkeinen
2026-05-15  6:58       ` Krzysztof Kozlowski
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 06/16] drm/tidss: Remove extra pm_runtime_mark_last_busy Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 07/16] drm/tidss: oldi: Remove define for unused register OLDI_LB_CTRL Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 08/16] drm/tidss: Add mechanism to detect DPI output Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 09/16] drm/tidss: Add external data and sync signal edge configuration Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 10/16] drm/tidss: Add support for DPIENABLE bit Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 11/16] drm/tidss: oldi: Fix OLDI signal polarities Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 12/16] drm/tidss: oldi: Convert OLDI to an aux driver Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 13/16] drm/tidss: Add support for AM62P display subsystem Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 14/16] arm64: dts: ti: k3-am62p-j722s-common-main: Make main_conf a syscon Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 15/16] arm64: dts: ti: k3-am62p-j722s-common-main: Add support for DSS Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-13 13:17 ` [PATCH v2 16/16] arm64: dts: ti: beagley-ai: Enable HDMI display and audio Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-05-16  2:00 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20 12:54 [PATCH 00/15] drm/tidss: Add BeagleY-AI display support (and some more) Tomi Valkeinen
2026-04-22 23:45 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox