public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: driver core: remove software node from platform devices on device release
Date: Sat, 16 May 2026 11:52:19 +1000	[thread overview]
Message-ID: <review-overall-20260513-swnode-remove-on-dev-unreg-v6-0-f9c58939df27@oss.qualcomm.com> (raw)
In-Reply-To: <20260513-swnode-remove-on-dev-unreg-v6-0-f9c58939df27@oss.qualcomm.com>

Overall Series Review

Subject: driver core: remove software node from platform devices on device release
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Patches: 8
Reviewed: 2026-05-16T11:52:19.024941

---

This is a well-structured 6-patch series from Bartosz Golaszewski that fixes a real software node lifecycle bug in the platform device subsystem. When a software node is specified via `struct platform_device_info`, it leaks on device release (and subsequent re-registration fails with `-EBUSY`). The approach is sound: patch 1 provides a minimal targeted fix for v7.1, patches 2-3 convert drivers that would regress under a unified release path, patch 4 unifies the release path, and patches 5-6 add kunit test infrastructure and test coverage.

The overall design is correct and the refcount logic in patch 4 is carefully thought through. However, **patch 2 has a significant bug**: the `surface_gpe_exit()` function is not updated, leaving a `fwnode_remove_software_node()` call that will operate on a managed software node that has already been freed during `platform_device_unregister()` -- a use-after-free.

**DRM-relevant patches**: Patch 3 (xe_i2c) is clean and correct. Ack recommended.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  1:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 15:04 [PATCH v6 0/6] driver core: remove software node from platform devices on device release Bartosz Golaszewski
2026-05-13 15:04 ` [PATCH v6 1/6] driver core: platform: remove software node on release() Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 2/6] platform/surface: gpe: use platform_device_register_full() Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 3/6] drm/xe/i2c: use device_create_managed_software_node() Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 4/6] driver core: platform: unify release path Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 5/6] kunit: provide kunit_software_node_register() Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 6/6] driver core: platform: tests: add test cases for correct swnode removal Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-14  0:24 ` (subset) [PATCH v6 0/6] driver core: remove software node from platform devices on device release Danilo Krummrich
2026-05-16  1:52 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12 11:59 [PATCH v5 0/7] " Bartosz Golaszewski
2026-05-16  3:28 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260513-swnode-remove-on-dev-unreg-v6-0-f9c58939df27@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox