public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: driver core: platform: remove software node on release()
Date: Sat, 16 May 2026 11:52:19 +1000	[thread overview]
Message-ID: <review-patch1-20260513-swnode-remove-on-dev-unreg-v6-1-f9c58939df27@oss.qualcomm.com> (raw)
In-Reply-To: <20260513-swnode-remove-on-dev-unreg-v6-1-f9c58939df27@oss.qualcomm.com>

Patch Review

**Correct and well-contained fix.** This adds a `platform_device_release_full()` wrapper that calls `device_remove_software_node()` before the standard release, and uses it only when a swnode is explicitly added via `pdevinfo->swnode`.

The expanded validation of mutually-exclusive software node sources is good:

```c
if ((pdevinfo->swnode && pdevinfo->properties) ||
    (pdevinfo->swnode && is_software_node(pdevinfo->fwnode)) ||
    (pdevinfo->properties && is_software_node(pdevinfo->fwnode)))
    return ERR_PTR(-EINVAL);
```

This correctly catches all three ways two software nodes could collide.

The release callback override placement is correct -- it's set after `device_add_software_node()` succeeds, so only devices with a secondary swnode get the new release callback:

```c
pdev->dev.release = platform_device_release_full;
```

**Minor nit**: commit message has "additonally" (should be "additionally").

**Verdict**: Looks correct as a standalone v7.1 fix.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  1:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 15:04 [PATCH v6 0/6] driver core: remove software node from platform devices on device release Bartosz Golaszewski
2026-05-13 15:04 ` [PATCH v6 1/6] driver core: platform: remove software node on release() Bartosz Golaszewski
2026-05-16  1:52   ` Claude Code Review Bot [this message]
2026-05-13 15:04 ` [PATCH v6 2/6] platform/surface: gpe: use platform_device_register_full() Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 3/6] drm/xe/i2c: use device_create_managed_software_node() Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 4/6] driver core: platform: unify release path Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 5/6] kunit: provide kunit_software_node_register() Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 6/6] driver core: platform: tests: add test cases for correct swnode removal Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot
2026-05-14  0:24 ` (subset) [PATCH v6 0/6] driver core: remove software node from platform devices on device release Danilo Krummrich
2026-05-16  1:52 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12 11:59 [PATCH v5 0/7] " Bartosz Golaszewski
2026-05-12 11:59 ` [PATCH v5 5/7] driver core: platform: remove software node on release() Bartosz Golaszewski
2026-05-16  3:28   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260513-swnode-remove-on-dev-unreg-v6-1-f9c58939df27@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox