From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: driver core: platform: unify release path
Date: Sat, 16 May 2026 11:52:20 +1000 [thread overview]
Message-ID: <review-patch4-20260513-swnode-remove-on-dev-unreg-v6-4-f9c58939df27@oss.qualcomm.com> (raw)
In-Reply-To: <20260513-swnode-remove-on-dev-unreg-v6-4-f9c58939df27@oss.qualcomm.com>
Patch Review
**Correct, with careful refcount handling.** This moves `device_remove_software_node()` into the base `platform_device_release()` and removes the separate `platform_device_release_full()` introduced in patch 1.
The key subtlety is the `fwnode_handle_get()` for software nodes passed as primary fwnode:
```c
if (is_software_node(pdevinfo->fwnode))
fwnode_handle_get(pdevinfo->fwnode);
```
This is necessary because `device_remove_software_node()` in the release path calls `kobject_put()` on whatever software node it finds. If the primary fwnode IS a software node (user-owned, not created by the platform code), the put would steal a reference the caller still holds. The extra get counterbalances this.
The placement before `platform_device_add_resources()` is correct: if any subsequent operation fails and we fall through to `err:`, `platform_device_put()` triggers the release callback, which calls `device_remove_software_node()`, which will consume the extra reference. Balanced.
The three cases work out:
- **Primary is software node, no secondary**: Extra get protects caller's reference; release puts it back.
- **Primary is non-swnode, secondary via pdevinfo->swnode**: No extra get needed; `device_remove_software_node()` removes the secondary swnode (added by this code).
- **Properties (managed secondary)**: Managed node is already cleaned by `software_node_notify_remove()` during `device_del()`; by the time `platform_device_release()` runs, `dev_to_swnode()` returns NULL, so `device_remove_software_node()` is a no-op.
**Verdict**: Correct.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 1:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 15:04 [PATCH v6 0/6] driver core: remove software node from platform devices on device release Bartosz Golaszewski
2026-05-13 15:04 ` [PATCH v6 1/6] driver core: platform: remove software node on release() Bartosz Golaszewski
2026-05-16 1:52 ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 2/6] platform/surface: gpe: use platform_device_register_full() Bartosz Golaszewski
2026-05-16 1:52 ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 3/6] drm/xe/i2c: use device_create_managed_software_node() Bartosz Golaszewski
2026-05-16 1:52 ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 4/6] driver core: platform: unify release path Bartosz Golaszewski
2026-05-16 1:52 ` Claude Code Review Bot [this message]
2026-05-13 15:04 ` [PATCH v6 5/6] kunit: provide kunit_software_node_register() Bartosz Golaszewski
2026-05-16 1:52 ` Claude review: " Claude Code Review Bot
2026-05-13 15:04 ` [PATCH v6 6/6] driver core: platform: tests: add test cases for correct swnode removal Bartosz Golaszewski
2026-05-16 1:52 ` Claude review: " Claude Code Review Bot
2026-05-14 0:24 ` (subset) [PATCH v6 0/6] driver core: remove software node from platform devices on device release Danilo Krummrich
2026-05-16 1:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260513-swnode-remove-on-dev-unreg-v6-4-f9c58939df27@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox