Claude review: Add Lontium LT7911EXC eDP to MIPI DSI bridge

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add Lontium LT7911EXC eDP to MIPI DSI bridge
Author: syyang@lontium.com
Patches: 3
Reviewed: 2026-05-25T22:53:57.625116

---

This is v10 of a 2-patch series adding support for the Lontium LT7911EXC eDP-to-MIPI-DSI bridge chip. The dt-binding patch (1/2) already has Reviewed-by from Krzysztof Kozlowski and looks clean. The driver patch (2/2) has Reviewed-by from Dmitry Baryshkov and is generally well-structured, following patterns from the existing `lontium-lt9611uxc.c` and `lontium-lt8713sx.c` drivers.

The series has been through significant iteration and the major issues from earlier versions (sleeping in atomic context, firmware loading under lock, uninitialized memory leaks in DSI reads) have been addressed. However, several issues remain, ranging from a correctness bug in firmware error paths to minor style concerns.

**Key issues:**
1. **Firmware error path bug**: `lt7911exc_write_data` is called with the original `fw` but `addr=0`, yet earlier the firmware was padded into a temporary `buffer`. The firmware data written is from the original `fw->data`, but the CRC is computed on the padded `buffer`. If `fw->size < total_size`, the CRC will not match what was actually written to flash.
2. **Redundant `dev_set_drvdata` / `i2c_set_clientdata`**: Both set the same underlying drvdata; the driver uses both `dev_get_drvdata` (sysfs) and `i2c_get_clientdata` (remove), so only `i2c_set_clientdata` is needed.
3. **Missing `regmap_noinc_write`**: Writing firmware blocks to a FIFO register should use `regmap_noinc_write`, not `regmap_raw_write`.
4. **Version read without MCU halt**: Departs from the established pattern in other Lontium drivers without adequate justification.

---

---
Generated by Claude Code Patch Reviewer