Claude review: Add Lontium LT7911EXC eDP to MIPI DSI bridge

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add Lontium LT7911EXC eDP to MIPI DSI bridge
Author: syyang@lontium.com
Patches: 3
Reviewed: 2026-05-25T19:24:23.492649

---

This is v11 of a 2-patch series adding a DRM bridge driver for the Lontium LT7911EXC eDP-to-MIPI-DSI bridge chip. The DT binding (patch 1) has a `Reviewed-by` from Krzysztof Kozlowski and looks clean. The driver (patch 2) has been through significant rework over 11 revisions, with many bug fixes driven by automated review. The overall structure is reasonable, but there are still several issues ranging from correctness bugs to locking concerns and API usage problems that should be addressed before merging.

**Key concerns:**
1. Firmware upgrade worker has error-path goto ordering bugs leading to firmware leaks and use-after-free of `fw` pointer.
2. The `lt7911exc_write_data` function writes through the raw `fw` pointer but the firmware was padded and CRC'd from a copy in `buffer` — the data written to the chip does not match the CRC if `fw->size < FW_SIZE - 4`.
3. Multiple regmap write calls have unchecked return values in the flash programming paths.
4. Locking design has holes — the `upgrade_lock` is released before the erase/write sequence finishes in the sysfs store path, so a concurrent store can race.
5. The sysfs attribute naming violates kernel conventions (should not include the driver name prefix).
6. Use of `drm_bridge_add`/`drm_bridge_remove` instead of `devm_drm_bridge_add`.

---

---
Generated by Claude Code Patch Reviewer