public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu/drm: bridge: tc358768: Add delay after PLL setup
Date: Mon, 25 May 2026 22:05:01 +1000	[thread overview]
Message-ID: <review-overall-20260520092628.47539-1-clamor95@gmail.com> (raw)
In-Reply-To: <20260520092628.47539-1-clamor95@gmail.com>

Overall Series Review

Subject: gpu/drm: bridge: tc358768: Add delay after PLL setup
Author: Svyatoslav Ryhel <clamor95@gmail.com>
Patches: 2
Reviewed: 2026-05-25T22:05:01.975192

---

This is a single-patch series adding a 20ms `msleep()` delay after PLL setup in the TC358768 DSI bridge driver. The fix addresses a real hardware issue on the TF700T (ASUS Transformer Pad Infinity) where the PLL reports lock but the clock hasn't fully stabilized, resulting in a blank screen.

The change is small, low-risk, and placed at the correct location. The existing `tc358768_setup_pll()` already has a 1-2ms `usleep_range()` for PLL lock, then enables `PLL_CKEN`. The new delay gives the clock output time to settle after `PLL_CKEN` is asserted — a distinct and valid concern from the lock wait itself. The patch has a Tested-by tag on the affected hardware.

**Verdict**: Looks reasonable. One minor concern worth raising.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-25 12:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20  9:26 [PATCH v1 0/1] gpu/drm: bridge: tc358768: Add delay after PLL setup Svyatoslav Ryhel
2026-05-20  9:26 ` [PATCH v1 1/1] " Svyatoslav Ryhel
2026-05-25 12:05   ` Claude review: " Claude Code Review Bot
2026-05-25 12:05 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260520092628.47539-1-clamor95@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox