From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/meson: clean up KMS polling on register failure
Date: Mon, 25 May 2026 17:01:26 +1000 [thread overview]
Message-ID: <review-overall-20260524160657.17802-1-mhun512@gmail.com> (raw)
In-Reply-To: <20260524160657.17802-1-mhun512@gmail.com>
Overall Series Review
Subject: drm/meson: clean up KMS polling on register failure
Author: Myeonghun Pak <mhun512@gmail.com>
Patches: 1
Reviewed: 2026-05-25T17:01:26.997575
---
This is a single-patch series that fixes a missing cleanup of the KMS polling helper in the error path of `meson_drv_bind_master()`. The fix is correct, minimal, and follows kernel conventions. The bug is real: `drm_kms_helper_poll_init()` is called at line 349, and if `drm_dev_register()` at line 353 subsequently fails, the original code jumped to `uninstall_irq` — skipping the necessary `drm_kms_helper_poll_fini()` call. This would leave a polling work item active against a device that is being torn down, which could lead to use-after-free or other memory corruption.
The fix adds an `uninstall_poll` label that calls `drm_kms_helper_poll_fini(drm)` before falling through to `uninstall_irq`. The unwinding order mirrors the initialization order (poll init → register, so unwind is: unregister-fail → poll fini → free irq), which is the standard kernel pattern.
**Verdict: Good patch, recommend accept.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 16:01 [PATCH] drm/meson: clean up KMS polling on register failure Myeonghun Pak
2026-05-25 7:01 ` Claude Code Review Bot [this message]
2026-05-25 7:01 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260524160657.17802-1-mhun512@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox