From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/meson: clean up KMS polling on register failure
Date: Mon, 25 May 2026 17:01:27 +1000 [thread overview]
Message-ID: <review-patch1-20260524160657.17802-1-mhun512@gmail.com> (raw)
In-Reply-To: <20260524160657.17802-1-mhun512@gmail.com>
Patch Review
**Correctness: Correct.**
The initialization sequence in `meson_drv_bind_master()` is:
```c
// line 343: request_irq(priv->vsync_irq, ...)
// line 349: drm_kms_helper_poll_init(drm)
// line 353: drm_dev_register(drm, 0)
```
The error unwind must be in reverse order: poll_fini → free_irq. The patch achieves this correctly:
```c
uninstall_poll:
drm_kms_helper_poll_fini(drm);
uninstall_irq:
free_irq(priv->vsync_irq, drm);
```
This also matches the normal teardown order in `meson_drv_unbind()` (lines 406-409), which does `drm_dev_unregister` → `drm_kms_helper_poll_fini` → `free_irq`.
**Fixes tag:** The `Fixes:` tag references `bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")`, which is the commit that introduced this function. This is appropriate since the bug has existed since the original code.
**Stable tag:** The `Cc: stable@vger.kernel.org` tag is appropriate for a resource-leak/use-after-free fix on an error path.
**No issues found.** The patch is minimal, correct, and well-described. The commit message accurately explains the problem and the fix.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 16:01 [PATCH] drm/meson: clean up KMS polling on register failure Myeonghun Pak
2026-05-25 7:01 ` Claude review: " Claude Code Review Bot
2026-05-25 7:01 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260524160657.17802-1-mhun512@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox