From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/atomic: track individual colorop updates
Date: Tue, 26 May 2026 07:18:46 +1000 [thread overview]
Message-ID: <review-overall-20260525100524.304263-1-mwen@igalia.com> (raw)
In-Reply-To: <20260525100524.304263-1-mwen@igalia.com>
Overall Series Review
Subject: drm/atomic: track individual colorop updates
Author: Melissa Wen <mwen@igalia.com>
Patches: 5
Reviewed: 2026-05-26T07:18:46.332271
---
This is a well-structured v7 series that solves a real bug: colorop property changes (e.g., shaper/3D-LUT updates in gamescope night mode) were not being tracked, so the AMD display driver never reprogrammed its color blocks. The fix is clean and follows the existing pattern used for CRTC `color_mgmt_changed`.
The series logically progresses: patches 1-2 make lut interpolation properties mutable (moving them from `drm_colorop` to `drm_colorop_state`), patch 3 wires up change tracking in the DRM core, and patch 4 consumes the new flag in the AMD driver. The approach is correct and the code is well-reviewed (Harry Wentland, Chaitanya Kumar Borah R-b tags).
No correctness bugs found. One minor observation and one minor nit below.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 21:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 9:49 [PATCH v7 0/4] drm/atomic: track individual colorop updates Melissa Wen
2026-05-25 9:49 ` [PATCH v7 1/4] drm/colorop: Remove read-only comments from interpolation fields Melissa Wen
2026-05-25 21:18 ` Claude review: " Claude Code Review Bot
2026-05-25 9:49 ` [PATCH v7 2/4] drm/colorop: make lut(1/3)d_interpolation mutable Melissa Wen
2026-05-25 21:18 ` Claude review: " Claude Code Review Bot
2026-05-25 9:50 ` [PATCH v7 3/4] drm/atomic: track individual colorop updates Melissa Wen
2026-05-25 21:18 ` Claude review: " Claude Code Review Bot
2026-05-25 9:50 ` [PATCH v7 4/4] drm/amd/display: use plane color_mgmt_changed to track colorop changes Melissa Wen
2026-05-25 21:18 ` Claude review: " Claude Code Review Bot
2026-05-25 21:18 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-19 21:09 [PATCH v6 0/6] drm/atomic: track individual colorop updates Melissa Wen
2026-05-19 21:09 ` [PATCH v6 5/6] " Melissa Wen
2026-05-25 12:24 ` Claude review: " Claude Code Review Bot
2026-05-25 12:24 ` Claude Code Review Bot
2026-05-06 19:23 [PATCH v5 0/6] " Melissa Wen
2026-05-06 19:23 ` [PATCH v5 5/6] " Melissa Wen
2026-05-07 3:05 ` Claude review: " Claude Code Review Bot
2026-05-07 3:05 ` Claude Code Review Bot
2026-05-01 13:06 [PATCH v4 0/6] drm/atomic: track colorop changes of a given plane Melissa Wen
2026-05-01 13:06 ` [PATCH v4 5/6] drm/atomic: track individual colorop updates Melissa Wen
2026-05-04 23:26 ` Claude review: " Claude Code Review Bot
2026-03-23 13:15 [PATCH v2 0/2] drm/atomic: track colorop changes of a given plane Melissa Wen
2026-03-23 13:15 ` [PATCH v2 1/2] drm/atomic: track individual colorop updates Melissa Wen
2026-03-24 21:51 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260525100524.304263-1-mwen@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox