public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ivpu: Remove disable_d0i3_msg workaround
Date: Wed, 27 May 2026 14:51:17 +1000	[thread overview]
Message-ID: <review-overall-20260526125521.594479-1-andrzej.kacprowski@linux.intel.com> (raw)
In-Reply-To: <20260526125521.594479-1-andrzej.kacprowski@linux.intel.com>

Overall Series Review

Subject: accel/ivpu: Remove disable_d0i3_msg workaround
Author: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
Patches: 2
Reviewed: 2026-05-27T14:51:17.107370

---

This is a single, well-scoped cleanup patch that removes the `disable_d0i3_msg` workaround from the Intel VPU (NPU) accelerator driver. The rationale is clear: all published firmware versions support D0i3 delayed entry, and newer firmware has dropped the legacy path entirely, making the workaround dead code.

The patch is **straightforward and correct**. All references to the workaround are consistently removed across all four files — the workaround flag in the WA table, the test mode bits, the initialization function, the conditional in boot params setup, and the early-return guard in the JSM D0i3 entry path. The `d0i3_delayed_entry` boot param is now unconditionally set to 1, which is the safe/correct value for all supported firmware.

The patch also bumps the boot API patch version (4 → 5) and updates the documentation comment for the `d0i3_delayed_entry` field to note deprecation on NPU50xx+, which is a good practice.

**No bugs or issues found.** This is a clean removal of dead code with no functional concerns.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-27  4:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 12:55 [PATCH] accel/ivpu: Remove disable_d0i3_msg workaround Andrzej Kacprowski
2026-05-26 13:03 ` Wachowski, Karol
2026-05-27  4:51 ` Claude Code Review Bot [this message]
2026-05-27  4:51 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260526125521.594479-1-andrzej.kacprowski@linux.intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox